[src/api] Update haml_lint 0.59.0 → 0.60.0 (major)

src/api/Gemfile.lock

@@ -208,7 +208,7 @@ GEM
       activesupport (>= 5.1)
       haml (>= 4.0.6)
       railties (>= 5.1)
-    haml_lint (0.59.0)
+    haml_lint (0.60.0)
       haml (>= 5.0)
       parallel (~> 1.10)
       rainbow

src/api/app/views/webui/request/_actions_details.html.haml

@@ -50,7 +50,7 @@
 
 - if %w[add_role set_bugowner].include?(action.type)
   :ruby
-    parameters = { project: action.target_project, request_action_id: action.id, notification_id: @current_notification }
+    parameters = { project: action.target_project, request_action_id: action.id, notification_id: current_notification }
     roles_link = if action.target_package
                    package_users_path(parameters.merge!(package: action.target_package))
                  else

src/api/app/views/webui/request/_request_header.html.haml

@@ -75,7 +75,8 @@
     = render partial: 'actions_details', locals: { bs_request: bs_request, action: action,
                                                     prev_action: prev_action, next_action: next_action,
                                                     actions: actions, diff_to_superseded_id: diff_to_superseded_id,
-                                                    page_name: page_name }
+                                                    page_name: page_name, notification_id: current_notification,
+                                                    current_notification: current_notification}
   - if Flipper.enabled?(:labels, User.session)
     .mt-4
       = render partial: 'webui/shared/label', collection: bs_request.labels, as: :label

src/api/app/views/webui/request/beta_show.html.haml

@@ -11,7 +11,8 @@
     = render partial: 'request_header',
         locals: { bs_request: @bs_request, staging_status: @staging_status, action: @action,
                   prev_action: @prev_action, next_action: @next_action, actions: @actions,
-                  diff_to_superseded_id: @diff_to_superseded_id, page_name: '' }
+                  diff_to_superseded_id: @diff_to_superseded_id, page_name: '',
+                  current_notification: @current_notification }
     = render partial: 'request_tabs',
         locals: { bs_request: @bs_request, action: @action, issues: @issues,
                   actions_count: @actions.count, active_tab: @active_tab }

src/api/app/views/webui/request/build_results.html.haml

@@ -9,7 +9,8 @@
         locals: { bs_request: @bs_request, staging_status: @staging_status, action: @action,
                   prev_action: @prev_action, next_action: @next_action, actions: @actions,
                   diff_to_superseded_id: @diff_to_superseded_id, page_name: 'request_build_results',
-                  bs_requests: @watched_requests, packages: @watched_packages, projects: @watched_projects }
+                  bs_requests: @watched_requests, packages: @watched_packages, projects: @watched_projects,
+                  current_notification: @current_notification }
     = render partial: 'request_tabs',
         locals: { bs_request: @bs_request, action: @action, issues: @issues,
                   actions_count: @actions.count, active_tab: @active_tab }

src/api/app/views/webui/request/changes.html.haml

@@ -9,7 +9,8 @@
         locals: { bs_request: @bs_request, staging_status: @staging_status, action: @action,
                   prev_action: @prev_action, next_action: @next_action, actions: @actions,
                   diff_to_superseded_id: @diff_to_superseded_id, page_name: 'request_changes',
-                  bs_requests: @watched_requests, packages: @watched_packages, projects: @watched_projects }
+                  bs_requests: @watched_requests, packages: @watched_packages, projects: @watched_projects,
+                  current_notification: @current_notification }
     = render partial: 'request_tabs',
         locals: { bs_request: @bs_request, action: @action, issues: @issues,
                   actions_count: @actions.count, active_tab: @active_tab }

src/api/app/views/webui/request/mentioned_issues.html.haml

@@ -9,7 +9,8 @@
         locals: { bs_request: @bs_request, staging_status: @staging_status, action: @action,
                   prev_action: @prev_action, next_action: @next_action, actions: @actions,
                   diff_to_superseded_id: @diff_to_superseded_id, page_name: 'request_mentioned_issues',
-                  bs_requests: @watched_requests, packages: @watched_packages, projects: @watched_projects }
+                  bs_requests: @watched_requests, packages: @watched_packages, projects: @watched_projects,
+                  current_notification: @current_notification }
     = render partial: 'request_tabs',
         locals: { bs_request: @bs_request, action: @action, issues: @issues,
                   actions_count: @actions.count, active_tab: @active_tab }

src/api/app/views/webui/request/rpm_lint.html.haml

@@ -9,7 +9,8 @@
         locals: { bs_request: @bs_request, staging_status: @staging_status, action: @action,
                   prev_action: @prev_action, next_action: @next_action, actions: @actions,
                   diff_to_superseded_id: @diff_to_superseded_id, page_name: 'request_rpm_lint',
-                  bs_requests: @watched_requests, packages: @watched_packages, projects: @watched_projects }
+                  bs_requests: @watched_requests, packages: @watched_packages, projects: @watched_projects,
+                  current_notification: @current_notification }
     = render partial: 'request_tabs',
         locals: { bs_request: @bs_request, action: @action, issues: @issues,
                   actions_count: @actions.count, active_tab: @active_tab }

src/api/app/views/webui/staging/projects/_status_items.html.haml

@@ -15,5 +15,5 @@
             link_to("#{item[:package]} by #{item[:by]}", request_show_path(item[:request]))
           when 'building_repositories'
             link_to("#{item['repository']}-#{item['arch']} (#{item['state']})",
-                    project_repository_state_path(project: @staging_project.name, repository: item['repository']))
+                    project_repository_state_path(project: staging_project.name, repository: item['repository']))
           end

src/api/spec/features/beta/webui/requests_spec.rb

@@ -0,0 +1,28 @@
+require 'browser_helper'
+
+RSpec.describe 'Requests' do
+  let(:submitter) { create(:confirmed_user, :with_home, login: 'kugelblitz') }
+  let(:receiver) { create(:confirmed_user, :with_home, login: 'titan') }
+  let(:target_project) { receiver.home_project }
+
+  context 'for role addition user' do
+    describe 'for projects' do
+      before do
+        login submitter
+        visit project_show_path(project: target_project)
+        desktop? ? click_on('Request Role Addition') : click_menu_link('Actions', 'Request Role Addition')
+        choose 'Bugowner'
+        choose 'User'
+        fill_in 'User:', with: submitter.login.to_s
+        fill_in 'Description:', with: 'I can fix bugs too.'
+      end
+
+      it 'can be submitted' do
+        expect { click_on('Request') }.to change(BsRequest, :count).by(1)
+        expect(page).to have_text("#{submitter.realname} (#{submitter.login}) wants to get the role bugowner for project #{target_project}")
+        expect(page).to have_css('#description-text', text: 'I can fix bugs too.')
+        expect(page).to have_css('.badge', text: 'new')
+      end
+    end
+  end
+end