Refactor reconciler logic

[vaibhavjainwiz]

Description

I had refactor the all reconciliation loops of odh-model-controller by following below guideline:
https://docs.google.com/document/d/1Q7ziQa_DtqtHnP9oWKNVgWNboYL0LhkdsHXl43QtXqI/edit?usp=sharing

Refactoring would fix the #86 issue.

How Has This Been Tested?

• Create a new cluster
• Setup the cluster with below Installation step
  https://github.com/opendatahub-io/caikit-tgis-serving/blob/main/demo/kserve/install-manual.md
• In Step 11, do not run oc create -f custom-manifests/opendatahub/kserve-dsc.yaml cmd. Instead create an instance of DataScienceCluster using below CRD:

---
kind: DataScienceCluster
apiVersion: datasciencecluster.opendatahub.io/v1
metadata:
  labels:
    app.kubernetes.io/created-by: opendatahub-operator
    app.kubernetes.io/instance: default
    app.kubernetes.io/managed-by: kustomize
    app.kubernetes.io/name: datasciencecluster
    app.kubernetes.io/part-of: opendatahub-operator
  name: default
spec:
  components:
    kserve:
      managementState: Managed
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: overlays/odh
            uri: https://github.com/opendatahub-io/kserve/tarball/master
          - contextDir: config
            uri: https://github.com/vaibhavjainwiz/odh-model-controller/tarball/fix_reconciler_manifest
    modelmeshserving:
      managementState: Managed
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: overlays/odh
            uri: https://github.com/opendatahub-io/modelmesh-serving/tarball/main
          - contextDir: config
            uri: https://github.com/vaibhavjainwiz/odh-model-controller/tarball/fix_reconciler_manifest

• Deploy/validate a Kserve model with below Step.
  https://github.com/opendatahub-io/caikit-tgis-serving/blob/main/demo/kserve/deploy-remove.md

If everything work as mentioned in above step then we are good to go :)

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[vaibhavjainwiz]

/test all

[spolti]

There are some files missing the license headers while others have.
Do we want to keep it aligned?

[vaibhavjainwiz]

There are some files missing the license headers while others have. Do we want to keep it aligned?

done

[openshift-ci]

@vaibhavjainwiz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/fvt	1b3a31c	link	true	/test fvt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[spolti]

before merge we might need to fix the failing test

[spolti]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidesalerno, spolti, vaibhavjainwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spolti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Jooho]

@spolti @davidesalerno could you please share how you test this? I followed the description and it failed to deploy odh-model-controller image. Moreover, it used a stable image, not the image built for this PR.

[vaibhavjainwiz]

@spolti @davidesalerno could you please share how you test this? I followed the description and it failed to deploy odh-model-controller image. Moreover, it used a stable image, not the image built for this PR.

@davidesalerno has faced the similiar issue. DSCInitialization settings are not picked by v2 operator automatically so we have to apply manifest manually and then it works.

[Jooho]

@vaibhavjainwiz @spolti i couldnt test this pr. @spolti please do not leave lgtm before testing. Openshif ci will merge if there is A lgtm on the PR.
@vaibhavjainwiz please update description for test steps properly.

[vaibhavjainwiz]

@vaibhavjainwiz @spolti i couldnt test this pr. @spolti please do not leave lgtm before testing. Openshif ci will merge if there is A lgtm on the PR. @vaibhavjainwiz please update description for test steps properly.

@Jooho I had updated the description for test. Please let me know if you are facing any issue to setup env.