Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to use two arm arch #411

Merged
merged 1 commit into from
May 31, 2023

Conversation

ghassanmas
Copy link
Member

Installing the bundle on arm based arch fails for deployment
it exit while complaining that platform doesn't exist gem lock
file, and suggest to add it by:
bundle lock --add-platform aarch64-linux

Fixes: overhangio/tutor-forum/issues/23

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 21, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4ca760a) 96.12% compared to head (b1a56b4) 96.12%.

❗ Current head b1a56b4 differs from pull request most recent head e14c1d6. Consider uploading reports for the commit e14c1d6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #411   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files          58       58           
  Lines        4568     4568           
=======================================
  Hits         4391     4391           
  Misses        177      177           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@itsjeyd
Copy link

itsjeyd commented Apr 26, 2023

Hi @ghassanmas, thanks for your contribution! Is it ready for review?

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 26, 2023
@ghassanmas
Copy link
Member Author

Yes, it is. :)

@itsjeyd
Copy link

itsjeyd commented Apr 26, 2023

label: core contributor

@github-actions github-actions bot added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Apr 26, 2023
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 26, 2023
@itsjeyd
Copy link

itsjeyd commented Apr 26, 2023

@ghassanmas OK, great :)

@asadazam93 This PR is ready for review by Infinity.

@itsjeyd
Copy link

itsjeyd commented May 3, 2023

Hi @asadazam93, a friendly ping about my previous comment. Do you have any updates on when this PR could be lined up for engineering review?

@asadazam93
Copy link
Contributor

@ghassanmas can you please rebase?

@ghassanmas
Copy link
Member Author

@asadazam93
Copy link
Contributor

@ghassanmas some checks are failing, can you please fix those?

@ghassanmas
Copy link
Member Author

ghassanmas commented May 25, 2023

I don't think the test fail is releavnt, I will to ammend commit to rerun tests, I only cahnged Ruby 3 lockfile, it shouldn't at all affect ruby 2 tests.

@ghassanmas
Copy link
Member Author

@asadazam93 the failing tests is related to CodeCov which is not uncommon, it fails to upload report or something, thus I don't thing its related to the code

@ghassanmas
Copy link
Member Author

This repo depends on codecov 0.6.0 and here which has been depreacted for over a year

On February 1, 2022 this uploader will be completely deprecated and will no longer be able to upload coverage to Codecov.

https://github.com/codecov/codecov-ruby#readme

@ghassanmas
Copy link
Member Author

@asadazam93 Also the logs complain that code cov token doesn't exits github env.

 Installing the bundle on arm based arch fails for deployment
 it exit while complaining that platform doesn't exist gem lock
 file, and suggest to add it by:
 `bundle lock --add-platform aarch64-linux`

 Fixes: overhangio/tutor-forum/issues/23
@ghassanmas
Copy link
Member Author

@asadazam93 it passed, and as expected without doing any thing beside amending the commmit. Something not right about those tests. In any case this is already deployed live/production the ARM image at https://lms.zaat.dev you can use [email protected] identified by 'zaatdemo' @ https://apps.lms.zaat.dev/discussions/course-v1:zaatdev+OX101+2023_4

@itsjeyd itsjeyd requested a review from asadazam93 May 31, 2023 07:25
@asadazam93 asadazam93 merged commit acc9b2f into openedx:master May 31, 2023
@openedx-webhooks
Copy link

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

ghassanmas added a commit to overhangio/tutor-forum that referenced this pull request Oct 2, 2023
ghassanmas added a commit to overhangio/tutor-forum that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Building the forum image fails on arm64
4 participants