Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport before palm.1 release #261

Closed
49 of 52 tasks
ghassanmas opened this issue Apr 13, 2023 · 7 comments
Closed
49 of 52 tasks

Backport before palm.1 release #261

ghassanmas opened this issue Apr 13, 2023 · 7 comments
Assignees
Milestone

Comments

@ghassanmas
Copy link
Member

ghassanmas commented Apr 13, 2023

Notes:

  • When a PR is merged to master, then it would be needed to create a PR to palm if one doesn't exsits and lastly to be merged to palm.

Exd-platform suggested by @bmtcril

Node v18 upgrade account and authn MFE are already upgraded, relate #254

Others

edx-platform suggested by @robrap

Other PRs from olive.3 relate #253

@mariajgrimaldi
Copy link
Member

I can help open the PR(s) for the edx-platform ones, but first I need to get my palm setup working. I'll let you know once I do it

@mariajgrimaldi mariajgrimaldi self-assigned this May 15, 2023
@ghassanmas
Copy link
Member Author

@mariajgrimaldi I think you can cherry-pick the commits togather, and open just one PR, assuming no need to test each one separately

@Ardiea
Copy link

Ardiea commented May 30, 2023

Hi, MIT would also like to request this PR backporting a stability fix for cs_comments to palm: openedx/cs_comments_service#409

@regisb
Copy link
Contributor

regisb commented Jun 9, 2023

The frontend-app-ecommerce MFE does not build on node 18. This MFE is required by the ecommerce plugin. See the Palm branch here: overhangio/tutor-ecommerce#41

frontend-app-ecommerce would at the very least require this patch, but maybe others as well: openedx/frontend-app-ecommerce@dcf9f9b

This is an important issue, as far as ecommerce is concerned. Should I open a separate issue?

cc @Faraz32123 who handled the ecommerce upgrade. If you have any idea to resolve this situation we are all ears 😅

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Jun 12, 2023

There's another backport we need: openedx/frontend-app-authoring#516 which fixes #278

Update: merged! 🥇

@mariajgrimaldi
Copy link
Member

@ghassanmas: should we close this issue and open a new one for palm.2?

@arbrandes
Copy link
Contributor

As per the title, I think so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

No branches or pull requests

6 participants