Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhancements to page (palm.master) #576

Conversation

vladislavkeblysh
Copy link
Contributor

  • Fixed font family on page
  • Fixed borders on action bar on mobile view
  • Fixed newest first text overlap another text
  • Fixed displaying user name on mobile view

Screenshot 2023-10-12 at 15 07 45
Screenshot 2023-10-12 at 15 07 18
Screenshot 2023-10-12 at 15 08 31
Screenshot 2023-10-12 at 15 08 15
Screenshot 2023-10-12 at 15 09 05
Screenshot 2023-10-12 at 15 08 51
Screenshot 2023-10-12 at 15 10 31
Screenshot 2023-10-12 at 15 10 14

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 12, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 12, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/enhancements-to-page-palm.master branch 2 times, most recently from c3ec014 to 82dfc72 Compare October 12, 2023 12:40
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 12, 2023
@itsjeyd itsjeyd added the backport PR backports a change from main to a named release. label Oct 17, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

@vladislavkeblysh Thank you for this contribution!

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dcb0f9e) 92.38% compared to head (f8daf7a) 92.40%.
Report is 4 commits behind head on open-release/palm.master.

Files Patch % Lines
...c/discussions/discussions-home/FeedbackWrapper.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           open-release/palm.master     #576      +/-   ##
============================================================
+ Coverage                     92.38%   92.40%   +0.01%     
============================================================
  Files                           163      162       -1     
  Lines                          3297     3278      -19     
  Branches                        890      883       -7     
============================================================
- Hits                           3046     3029      -17     
+ Misses                          232      230       -2     
  Partials                         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added product review PR requires product review before merging and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 17, 2023
@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 24, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 24, 2023

@vladislavkeblysh Looks like there are some coverage issues, can you have a look?

@vladislavkeblysh
Copy link
Contributor Author

@itsjeyd The coverage issues are not related to the new code added in this PR. It seems like this has been carrying over from previous PRs.

@itsjeyd
Copy link

itsjeyd commented Nov 8, 2023

@vladislavkeblysh Noted, thanks.

As I mentioned here, your reviewers will need to decide if that means the changes are good to merge as is.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 8, 2023
@awais-ansari
Copy link
Contributor

@vladislavkeblysh please resolve conflict. Some changes have been suggested here.

@awais-ansari
Copy link
Contributor

@vladislavkeblysh This change was intentional. This feature is still in product discussion.

@awais-ansari awais-ansari added engineering review waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed product review PR requires product review before merging engineering review labels Nov 8, 2023
@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Nov 15, 2023
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/enhancements-to-page-palm.master branch from 82dfc72 to f8daf7a Compare November 25, 2023 13:09
@vladislavkeblysh
Copy link
Contributor Author

vladislavkeblysh commented Nov 25, 2023

@awais-ansari All comments fixed and branch updated.

The coverage issues are not related to the new code added in this PR. It seems like this has been carrying over from previous PRs.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 29, 2023
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@mphilbrick211
Copy link

PR LGTM

We're just waiting on Product to confirm review.

@awais-ansari awais-ansari merged commit b513314 into openedx:open-release/palm.master Dec 14, 2023
5 of 6 checks passed
@openedx-webhooks
Copy link

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@awais-ansari awais-ansari added merged and removed product review PR requires product review before merging labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. merged open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants