Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhancements to page #577

Conversation

vladislavkeblysh
Copy link
Contributor

  • Fixed font family on page
  • Fixed borders on action bar on mobile view
  • Fixed newest first text overlap another text
  • Fixed displaying user name on mobile view

Screenshot 2023-10-12 at 15 07 45
Screenshot 2023-10-12 at 15 07 18
Screenshot 2023-10-12 at 15 08 31
Screenshot 2023-10-12 at 15 08 15
Screenshot 2023-10-12 at 15 09 05
Screenshot 2023-10-12 at 15 08 51
Screenshot 2023-10-12 at 15 10 31
Screenshot 2023-10-12 at 15 10 14

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 12, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 12, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 12, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

@vladislavkeblysh Thank you for this contribution!

@jmakowski1123 With this set of changes I'm not sure if we need to step through the full product review process. It seems like they are just fixing some small visual inconsistencies. What do you think?

CC @mphilbrick211

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67d79cb) 92.41% compared to head (009ccce) 92.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #577   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         169      169           
  Lines        3468     3468           
  Branches      900      900           
=======================================
  Hits         3205     3205           
  Misses        243      243           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added product review PR requires product review before merging and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 17, 2023
@itsjeyd
Copy link

itsjeyd commented Nov 2, 2023

@jmakowski1123 Friendly ping about this question -- do you think this PR needs a round of product review?

src/discussions/common/AuthorLabel.jsx Outdated Show resolved Hide resolved
src/index.scss Show resolved Hide resolved
src/index.scss Outdated Show resolved Hide resolved
src/index.scss Outdated Show resolved Hide resolved
@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. engineering review labels Nov 8, 2023
@awais-ansari awais-ansari removed product review PR requires product review before merging engineering review labels Nov 8, 2023
@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Nov 15, 2023
@itsjeyd
Copy link

itsjeyd commented Nov 17, 2023

@jmakowski1123 @awais-ansari It sounds like product review for this PR has already started (?). If so, could you please point me to where that conversation is happening? It doesn't seem like we have a feature ticket for this PR, so it's hard for me to tell what its current status is.

CC @mphilbrick211

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/enhancements-to-page-master branch 2 times, most recently from 97c3023 to a31ca8d Compare November 25, 2023 12:45
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/enhancements-to-page-master branch from cbafd73 to 5cf243c Compare November 25, 2023 12:50
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 29, 2023
@awais-ansari
Copy link
Contributor

awais-ansari commented Nov 30, 2023

@mphilbrick211 Is this PR still in a product review? or is it ready for merge?

Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@mphilbrick211
Copy link

mphilbrick211 commented Dec 1, 2023

@mphilbrick211 Is this PR still in a product review? or is it ready for merge?

@awais-ansari We haven't heard back from Product - so please hold off on merging.

CC: @jmakowski1123

@jmakowski1123
Copy link

This is approved.

@awais-ansari
Copy link
Contributor

@vladislavkeblysh Please update this PR.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 14, 2023
@vladislavkeblysh
Copy link
Contributor Author

@awais-ansari Done, thank you

@mphilbrick211
Copy link

All set to merge, @awais-ansari!

@awais-ansari
Copy link
Contributor

@vladislavkeblysh can you please update this PR one more time?

@awais-ansari awais-ansari added ready to merge and removed product review PR requires product review before merging waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Dec 18, 2023
@awais-ansari awais-ansari merged commit 6ae5130 into openedx:master Dec 18, 2023
7 checks passed
@openedx-webhooks
Copy link

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants