Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhancements to page (quince.master) #578

Conversation

vladislavkeblysh
Copy link
Contributor

  • Fixed font family on page
  • Fixed borders on action bar on mobile view
  • Fixed newest first text overlap another text
  • Fixed displaying user name on mobile view

Screenshot 2023-10-12 at 15 07 45
Screenshot 2023-10-12 at 15 07 18
Screenshot 2023-10-12 at 15 08 31
Screenshot 2023-10-12 at 15 08 15
Screenshot 2023-10-12 at 15 09 05
Screenshot 2023-10-12 at 15 08 51
Screenshot 2023-10-12 at 15 10 31
Screenshot 2023-10-12 at 15 10 14

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 12, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 12, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 12, 2023
@itsjeyd itsjeyd added the backport PR backports a change from main to a named release. label Oct 17, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

@vladislavkeblysh Thank you for this contribution!

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@eb127cd). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #578   +/-   ##
=============================================================
  Coverage                              ?   92.32%           
=============================================================
  Files                                 ?      169           
  Lines                                 ?     3451           
  Branches                              ?      899           
=============================================================
  Hits                                  ?     3186           
  Misses                                ?      244           
  Partials                              ?       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added product review PR requires product review before merging and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 17, 2023
@awais-ansari
Copy link
Contributor

@vladislavkeblysh please resolve conflict. Some changes have been suggested here.

@awais-ansari awais-ansari added engineering review waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed product review PR requires product review before merging engineering review labels Nov 8, 2023
@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Nov 15, 2023
@itsjeyd
Copy link

itsjeyd commented Nov 23, 2023

Hi @vladislavkeblysh, a friendly reminder to follow up on @awais-ansari's latest comment about resolving conflicts, and to address feedback that you got from @sundasnoreen12 on the main PR for this change (#577).

@vladislavkeblysh
Copy link
Contributor Author

@itsjeyd I will fix it soon, thank you!

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/enhancements-to-page-quince.master branch from 6f0bc04 to 662afd6 Compare November 25, 2023 12:49
@vladislavkeblysh
Copy link
Contributor Author

@itsjeyd All comments fixed and branch updated.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 29, 2023
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@arbrandes
Copy link
Contributor

Is this now just a matter of pressing the merge button? Should I do it? :)

@cmltaWt0
Copy link

The master PR still in open state.
#577

@awais-ansari awais-ansari merged commit e9e3db5 into openedx:open-release/quince.master Dec 14, 2023
6 checks passed
@openedx-webhooks
Copy link

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@awais-ansari awais-ansari removed the product review PR requires product review before merging label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. merged open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants