Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgraded to node v18, added .nvmrc and updated workflows #2227

Merged
merged 4 commits into from
May 18, 2023

Conversation

Mashal-m
Copy link
Contributor

Description

  • Added support for node v18, updated .nvmrc and workflows.
  • Updated @edx/browserslist-config, @edx/eslint-config, and @edx/stylelint-config-edx version

Ticket
Upgrade Node JS from 16 to 18

Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 3f972a5
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6465ce280cded20008a8a905
😎 Deploy Preview https://deploy-preview-2227--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6118e2c) 91.01% compared to head (3f972a5) 91.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2227   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files         234      234           
  Lines        4139     4139           
  Branches      991      991           
=======================================
  Hits         3767     3767           
  Misses        365      365           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mashal-m Mashal-m marked this pull request as ready for review April 25, 2023 12:26
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like there's a merge conflict with package-lock.json. Also, these changes should be released as a breaking change. Thanks!

@abdullahwaheed
Copy link
Contributor

LGTM, looks like there's a merge conflict with package-lock.json. Also, these changes should be released as a breaking change. Thanks!

Hi @adamstankiewicz! Since there aren't any breaking changes in this PR and there is no major version change in package.json, i think we can release it as minor version. If you have any particular scenario in mind in which it can break, please let us know so we can proceed to merge it

@abdullahwaheed abdullahwaheed merged commit 5d10aab into master May 18, 2023
@abdullahwaheed abdullahwaheed deleted the mashal-m/node18-upgrade branch May 18, 2023 08:22
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants