feat: 893 - 4 new fields for user #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `login_status.dart`: added 4 fields and deprecated "email" * `open_food_api_client.dart`: upgraded the max length of user name (60) and user id (40) * `user_management_test_prod.dart`: tested the new 4 login status fields * `user_management_test_test_env.dart`: tested the new 4 login status fields and remove a test on "email"
|
@monsieurtanuki PR to add a cc field: openfoodfacts/openfoodfacts-server#10152 ("world" can also be a value) |
alexgarel
pushed a commit
to openfoodfacts/openfoodfacts-server
that referenced
this pull request
Apr 19, 2024
add cc field requested by @monsieurtanuki in openfoodfacts/openfoodfacts-dart#903 note that cc can also be "world" also removed some fields if their value is undef or empty
|
@stephanegigandet I've just PR'ed the use of json field As mentioned in openfoodfacts/openfoodfacts-server#10152 (comment), so far I couldn't test it successfully in PROD as the field doesn't seem to be available. Besides, I'm not 100% sure it would be very clean to add a fake country called |
john-gom
pushed a commit
to openfoodfacts/openfoodfacts-server
that referenced
this pull request
May 24, 2024
add cc field requested by @monsieurtanuki in openfoodfacts/openfoodfacts-dart#903 note that cc can also be "world" also removed some fields if their value is undef or empty
|
Thank you @stephanegigandet: I've just tested in PROD and the |
|
ping |
M123-dev
approved these changes
Jul 6, 2024
|
Thank you @M123-dev for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
countryasen:france, which is not very easy to convert, whereasfrwould be perfectFixes bug(s)
Impacted files
login_status.dart: added 4 fields and deprecated "email"open_food_api_client.dart: upgraded the max length of user name (60) and user id (40)user_management_test_prod.dart: tested the new 4 login status fieldsuser_management_test_test_env.dart: tested the new 4 login status fields and remove a test on "email"