Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cc field to auth.pl #10152

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix: add cc field to auth.pl #10152

merged 1 commit into from
Apr 19, 2024

Conversation

stephanegigandet
Copy link
Contributor

add cc field requested by @monsieurtanuki in openfoodfacts/openfoodfacts-dart#903 (comment)

note that cc can also be "world"

also removed some fields if their value is undef or empty

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@alexgarel alexgarel merged commit 08d16b0 into main Apr 19, 2024
13 checks passed
@alexgarel alexgarel deleted the auth-cc branch April 19, 2024 15:04
@monsieurtanuki
Copy link
Contributor

@stephanegigandet Is it already working in PROD?
I've just got this response, with country but no cc:

{
  "status":1,
  "status_verbose":"user signed-in",
  "user":{
    "admin":0,
    "country":"en:france",
    "moderator":1,
    "name":"(my name)",
    "preferred_language":"fr"
  },
  "user_id":"monsieurtanuki"
}

after a call like that:

    final Uri uri = uriHelper.getPostUri(
      path: '/cgi/auth.pl',
    );
    final Response response = await HttpHelper().doPostRequest(
      uri,
      <String, String>{'body': '1'},
      user,
      uriHelper: uriHelper,
      addCredentialsToBody: true,
    );

@teolemon
Copy link
Member

Deployed to .net currently @monsieurtanuki

john-gom pushed a commit that referenced this pull request May 24, 2024
add cc field requested by @monsieurtanuki in openfoodfacts/openfoodfacts-dart#903 
note that cc can also be "world"

also removed some fields if their value is undef or empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants