-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-3618: Prevent submitting empty lab results form #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnasambu
force-pushed
the
(fix)O3-3618
branch
6 times, most recently
from
July 31, 2024 11:17
8e472ec
to
478d953
Compare
jwnasambu
force-pushed
the
(fix)O3-3618
branch
3 times, most recently
from
August 2, 2024 13:51
3778b1b
to
0dd13d3
Compare
jwnasambu
changed the title
(fix)O3-3618: Required Field Message Alert for Labs is Not Clear and …
(fix)O3-3618: Required Field Message Alert for Labs is Not Clear and is Not Noticeable
Aug 2, 2024
I've started a discussion on the approach here |
jwnasambu
force-pushed
the
(fix)O3-3618
branch
2 times, most recently
from
August 12, 2024 09:30
41f1411
to
847841c
Compare
denniskigen
force-pushed
the
(fix)O3-3618
branch
from
August 12, 2024 12:10
847841c
to
0dafb75
Compare
denniskigen
changed the title
(fix)O3-3618: Required Field Message Alert for Labs is Not Clear and is Not Noticeable
(fix) O3-3618: Validate against submitting empty lab results form
Aug 12, 2024
denniskigen
changed the title
(fix) O3-3618: Validate against submitting empty lab results form
(fix) O3-3618: Prevent submission of empty lab results form
Aug 12, 2024
jwnasambu
force-pushed
the
(fix)O3-3618
branch
from
August 13, 2024 21:44
1f00532
to
2a1384b
Compare
denniskigen
force-pushed
the
(fix)O3-3618
branch
from
August 17, 2024 19:41
b6ef011
to
0462f48
Compare
denniskigen
changed the title
(fix) O3-3618: Prevent submission of empty lab results form
(fix) O3-3618: Prevent submitting empty lab results form
Aug 17, 2024
denniskigen
force-pushed
the
(fix)O3-3618
branch
from
August 17, 2024 20:06
0462f48
to
e9dd9aa
Compare
denniskigen
force-pushed
the
(fix)O3-3618
branch
from
August 17, 2024 20:08
e9dd9aa
to
69dc873
Compare
denniskigen
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
I fixed the validation using Zod so that the system displays a prominent message indicating missing required fields, with these fields highlighted in red for better visibility.
Screenshots
screencast.2024-08-12.3.PM-46-11.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-3618
Other