Prevent NPE on UpgradeSpringFrameworkDependencies.newVersion
#390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanvr
approved these changes
Jul 17, 2023
timtebeek
added a commit
to openrewrite/rewrite-docs
that referenced
this pull request
Jul 17, 2023
These merely failed to load, which we're fixing in openrewrite/rewrite-spring#390 openrewrite/rewrite-github-actions#87
mike-solomon
pushed a commit
to openrewrite/rewrite-docs
that referenced
this pull request
Jul 17, 2023
These merely failed to load, which we're fixing in openrewrite/rewrite-spring#390 openrewrite/rewrite-github-actions#87
alexkir28
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen in the log output of builds; Weird, since
newVersionis a required argument.Might have something to do with openrewrite/rewrite#3404
Not entirely sure if this is what we'd want to be doing here, but figured open the PR to kick off discussion.