Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Micrometer 1.13.x upgrade to Spring Boot 3.3.x migration #551

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Add Micrometer 1.13.x upgrade to Spring Boot 3.3.x migration #551

merged 3 commits into from
Jul 12, 2024

Conversation

jjank
Copy link
Contributor

@jjank jjank commented Jul 12, 2024 •
edited
Loading

Partially resolves #526

What's changed?

What's your motivation?

  • Spring Boot 3.3.x includes Micrometer 1.13.x which introduced breaking changes

Anything in particular you'd like reviewers to focus on?

  • As Tim suggested I specifically included the migration to verison 1.13.x in the recipe list as opposed to the generic micrometer upgrade recipe to avoid "surprises" with regards to versions in the future

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jjank
Copy link
Contributor Author

jjank commented Jul 12, 2024

@timtebeek the compilation failure is also in main - I guess I'll wait for you guys to resolve this an then rebase my changes accordingly

timtebeek
timtebeek approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this quick addition following on from

Thanks again!

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@timtebeek timtebeek merged commit 196dc5f into openrewrite:main Jul 12, 2024
2 checks passed
@timtebeek timtebeek added enhancement New feature or request boot-3.3 labels Jul 12, 2024
@jjank jjank deleted the 526-boot-33-micrometer branch July 12, 2024 11:08
timtebeek added a commit that referenced this pull request Jul 16, 2024
@timtebeek
Revert "Add Micrometer 1.13.x upgrade to Spring Boot 3.3.x migration (#…
3edc1e0 
…551)"

This reverts commit 196dc5f.
@timtebeek timtebeek mentioned this pull request Aug 12, 2024
Merged
timtebeek added a commit that referenced this pull request Aug 12, 2024
@timtebeek
Upgrade Micrometer 1.13 as part of Spring Boot 3.3
974b9ae 
Follows
- #551
- 3edc1e0
- openrewrite/rewrite-micrometer#13
@timtebeek timtebeek mentioned this pull request Aug 12, 2024
Merged
timtebeek added a commit that referenced this pull request Aug 12, 2024
@timtebeek
Upgrade Micrometer 1.13 as part of Spring Boot 3.3 (#565)
a217982 
Follows
- #551
- 3edc1e0
- openrewrite/rewrite-micrometer#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@timtebeek timtebeek timtebeek approved these changes

Assignees

@jjank jjank

Labels
boot-3.3 enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add recipes to migrate to Spring Boot 3.3
2 participants
@jjank @timtebeek