Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Fix new home page small screen display issues #8554

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Oct 11, 2024

Description

Fix new home page small screen display and update workspace issues.

  1. When the browser shrinks, display a horizontal scrollbar.
image

Issues Resolved

N/A

Screenshot

2024-10-11.09.26.31.mp4

Testing the changes

Changelog

  • fix: Fix new home page small screen display issues

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (615d7d4) to head (c2dfc52).
Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8554      +/-   ##
==========================================
+ Coverage   60.95%   60.96%   +0.01%     
==========================================
  Files        3776     3776              
  Lines       89638    89680      +42     
  Branches    14045    14055      +10     
==========================================
+ Hits        54639    54674      +35     
- Misses      31587    31591       +4     
- Partials     3412     3415       +3     
Flag Coverage Δ
Linux_1 29.12% <ø> (+0.04%) ⬆️
Linux_2 56.28% <ø> (+<0.01%) ⬆️
Linux_3 37.80% <ø> (+0.05%) ⬆️
Linux_4 29.95% <ø> (+0.03%) ⬆️
Windows_1 29.13% <ø> (+0.04%) ⬆️
Windows_2 56.23% <ø> (+<0.01%) ⬆️
Windows_3 37.81% <ø> (+0.05%) ⬆️
Windows_4 29.95% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wanglam wanglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SuZhou-Joe
SuZhou-Joe previously approved these changes Oct 12, 2024
@yubonluo yubonluo changed the title [Workspace] Fix new home page small screen display issues [Workspace] Fix new home page small screen display and update workspace issues Oct 12, 2024
@yubonluo yubonluo changed the title [Workspace] Fix new home page small screen display and update workspace issues [Workspace] Fix new home page small screen display issues Oct 12, 2024
Signed-off-by: yubonluo <[email protected]>
@ruanyl ruanyl merged commit 0171068 into opensearch-project:main Oct 12, 2024
69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2024
* Fix small screen display issues

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #8554 created/updated

* revert

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 0171068)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Oct 12, 2024
)

* Fix small screen display issues



* Changeset file for PR #8554 created/updated

* revert



---------



(cherry picked from commit 0171068)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
…-project#8554)

* Fix small screen display issues

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR opensearch-project#8554 created/updated

* revert

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
…-project#8554)

* Fix small screen display issues

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR opensearch-project#8554 created/updated

* revert

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants