Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace] Fix new home page small screen display issues #8554

Merged
merged 4 commits into from
Oct 12, 2024
Merged

[Workspace] Fix new home page small screen display issues #8554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7f3f7d
Fix small screen display issues
yubonluo Oct 11, 2024
119050c
Changeset file for PR #8554 created/updated
opensearch-changeset-bot[bot] Oct 11, 2024
a832ed6
Merge branch 'main' into 2.17/home
yubonluo Oct 11, 2024
c2dfc52
revert
yubonluo Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/8554.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Fix new home page small screen display issues ([#8554](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8554))
40 changes: 24 additions & 16 deletions ...rkspace/public/components/workspace_initial/__snapshots__/workspace_initial.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/plugins/workspace/public/components/workspace_initial/workspace_initial.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@
margin: auto;
padding-left: 48px;
padding-right: 48px;
width: 100%;
}
17 changes: 11 additions & 6 deletions src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,12 @@ export const WorkspaceInitial = ({ registeredUseCases$ }: WorkspaceInitialProps)
</EuiFlexItem>
<EuiSpacer size="l" />
<EuiFlexItem grow={false}>
<EuiFlexGroup direction="row" justifyContent="spaceBetween" alignItems="center">
<EuiFlexGroup
direction="row"
justifyContent="spaceBetween"
alignItems="center"
gutterSize="m"
>
<EuiFlexItem grow={false}>
<div style={{ display: 'flex', alignItems: 'center' }}>
<EuiIcon type="wsSelector" size="m" />
Expand All @@ -181,8 +186,8 @@ export const WorkspaceInitial = ({ registeredUseCases$ }: WorkspaceInitialProps)
<EuiFlexItem grow={false}>{isDashboardAdmin && createWorkspacePopover}</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexItem>
<EuiFlexItem>
<EuiFlexGroup justifyContent="spaceBetween" gutterSize="m">
<EuiFlexItem grow={false}>
<EuiFlexGroup justifyContent="spaceBetween" gutterSize="m" className="eui-xScroll">
{useCaseCards}
</EuiFlexGroup>
</EuiFlexItem>
Expand Down Expand Up @@ -241,15 +246,15 @@ export const WorkspaceInitial = ({ registeredUseCases$ }: WorkspaceInitialProps)
return (
<EuiPage style={{ minHeight: '100vh' }}>
<EuiPageBody>
<EuiIcon type="logoOpenSearch" size="xl" />
<EuiIcon type="logoOpenSearch" size="xl" style={{ position: 'fixed' }} />
<EuiSpacer size="xl" />
<EuiSpacer size="l" />
<EuiFlexGroup
direction="column"
alignItems="center"
justifyContent="flexStart"
className="workspace-initial__flex-group-responsive"
>
<EuiFlexItem grow={false} style={{ width: '1264px' }}>
<EuiFlexItem grow={false} style={{ maxWidth: '1264px', width: '100%' }}>
{content}
</EuiFlexItem>
</EuiFlexGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/workspace/public/components/workspace_initial/workspace_use_case_card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export const WorkspaceUseCaseCard = ({
};

return (
<EuiSplitPanel.Outer style={{ height: '416px', minWidth: '235px' }}>
<EuiSplitPanel.Outer style={{ height: '416px', minWidth: '240px' }}>
<EuiSplitPanel.Inner
paddingSize="m"
grow={!hasWorkspaces}
Expand Down
Loading