[Discover] Fix error handling for ppl jobs API #8771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
joshuali925
approved these changes
Oct 30, 2024
ananzh
approved these changes
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8771 +/- ##
==========================================
+ Coverage 60.75% 60.77% +0.01%
==========================================
Files 3798 3798
Lines 90691 90688 -3
Branches 14275 14275
==========================================
+ Hits 55099 55112 +13
+ Misses 32093 32077 -16
Partials 3499 3499
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7 tasks
ananzh
pushed a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Oct 31, 2024
…arch-project#8771) Backport PR: opensearch-project#8771 From 8771: * fix error handling for ppl jobs API Signed-off-by: Shenoy Pratik <[email protected]> * Changeset file for PR opensearch-project#8771 created/updated --------- Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
7 tasks
ananzh
added a commit
that referenced
this pull request
Oct 31, 2024
…#8777) Backport PR: #8771 From 8771: * fix error handling for ppl jobs API * Changeset file for PR #8771 created/updated --------- Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/OpenSearch-Dashboards
that referenced
this pull request
Nov 1, 2024
* fix error handling for ppl jobs API Signed-off-by: Shenoy Pratik <[email protected]> * Changeset file for PR opensearch-project#8771 created/updated --------- Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up on #8706 based on error handling updates for SQL async jobs API #8765
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration