Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix discover query loading state #8832

Merged
merged 2 commits into from
Nov 14, 2024

fix discover loading state

3c1a512
Select commit
Loading
Failed to load commit list.
Merged

[Discover] Fix discover query loading state #8832

fix discover loading state
3c1a512
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 0s

60.87% (+0.00%) compared to aa60870

View this Pull Request on Codecov

60.87% (+0.00%) compared to aa60870

Details

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (aa60870) to head (3c1a512).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ublic/application/view_components/canvas/index.tsx 0.00% 4 Missing ⚠️
...ic/application/view_components/utils/use_search.ts 33.33% 2 Missing ⚠️
...query_string/language_service/lib/query_result.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8832   +/-   ##
=======================================
  Coverage   60.86%   60.87%           
=======================================
  Files        3799     3799           
  Lines       90761    90757    -4     
  Branches    14294    14291    -3     
=======================================
+ Hits        55246    55248    +2     
+ Misses      32005    32000    -5     
+ Partials     3510     3509    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.