Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote store restore optimization #16607

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

prayascoriolis
Copy link

Description

Key changes made:

  • Added a check to detect if there is preexisting data in the remote store.
  • Modified the copySegmentFiles call to skip remote upload when data already exists by passing null instead of remoteDirectory.
  • Preserved all other functionality including local file copying and verification.

This solution:

  • Prevents unnecessary uploads when restoring from an interop enabled repository.
  • Maintains data consistency by still performing local copies.
  • Preserves existing recovery state tracking and error handling.
  • Optimizes performance by avoiding redundant network transfers.
  • The change is backward compatible and maintains the existing recovery mechanisms while eliminating the unnecessary upload step when data already exists in the remote store.

Related Issues

Resolves #11044

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for a55ff72: SUCCESS

Copy link
Contributor

❌ Gradle check result for 0bdc6af: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Storage:Durability Issues and PRs related to the durability framework Storage:Remote
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Remote Store] Remove redundant uploads while restoring data from snapshot
2 participants