Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote store restore optimization #16607

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+59 −3
Open

Remote store restore optimization #16607

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b16e3b7
Optimize remote store restoration by skipping existing segments
prayascoriolis Nov 7, 2024
bda3023
Merge branch 'opensearch-project:main' into remote-store-restore-opti…
prayascoriolis Nov 11, 2024
d26fb12
Improved Comment. Signed-off-by: Prayas Kumar [email protected]…
prayascoriolis Nov 11, 2024
a55ff72
Added Comments. Signed-off-by: Prayas Kumar <[email protected]…
prayascoriolis Nov 11, 2024
0bdc6af
Check the latest state of uploaded data & add unit tests. Signed-off-…
prayascoriolis Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/src/main/java/org/opensearch/index/shard/IndexShard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5170,6 +5170,8 @@ public void syncSegmentsFromGivenRemoteSegmentStore(
}
Map<String, RemoteSegmentStoreDirectory.UploadedSegmentMetadata> uploadedSegments = sourceRemoteDirectory
.getSegmentsUploadedToRemoteStore();
// Checking for existing remote segments in remote
boolean hasPreexistingRemoteData = remoteDirectory != null && !remoteDirectory.getSegmentsUploadedToRemoteStore().isEmpty();
prayascoriolis marked this conversation as resolved.
Show resolved Hide resolved
store.incRef();
try {
final Directory storeDirectory;
Expand All @@ -5190,7 +5192,7 @@ public void syncSegmentsFromGivenRemoteSegmentStore(
String segmentsNFile = copySegmentFiles(
storeDirectory,
sourceRemoteDirectory,
remoteDirectory,
hasPreexistingRemoteData ? null : remoteDirectory, // Pass null to skip upload if pre-exsisting data is present,
prayascoriolis marked this conversation as resolved.
Show resolved Hide resolved
uploadedSegments,
overrideLocal,
() -> {}
Expand Down
Loading