Fix test for single node #1078
Merged
Fix test for single node #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: monusingh-1 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.9 #1078 +/- ##
============================================
+ Coverage 74.80% 75.93% +1.13%
- Complexity 1042 1058 +16
============================================
Files 141 141
Lines 4771 4771
Branches 546 546
============================================
+ Hits 3569 3623 +54
+ Misses 858 797 -61
- Partials 344 351 +7 |
| @@ -1221,6 +1221,12 @@ class StartReplicationIT: MultiClusterRestTestCase() { | |||
| } | |||
|
|
|||
| fun `test that wait_for_active_shards setting is updated on follower through start replication api`() { | |||
|
|
|||
| //Ignore this test if clusters dont have multiple nodes | |||
| if(!isMultiNodeClusterConfiguration){ | |||
There was a problem hiding this comment.
we will need to fix this, Can we create a backlog and attach to the method rather than skipping?
ankitkala
approved these changes
Jul 18, 2023
saikaranam-amazon
approved these changes
Jul 18, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip test when single node clusters are used.
wait_for_active_shards setting will not allow the index to close as more than 1 shard will not be active.
This causes the test to fail.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.