Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add microsoft teams support #44

Merged
merged 8 commits into from
Aug 28, 2023

Conversation

zhichao-aws
Copy link
Member

@zhichao-aws zhichao-aws commented May 17, 2023

Description

add Microsoft Teams support at front-end

Issues Resolved

opensearch-project/notifications#585

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: zhichao-aws <[email protected]>
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #44 (738935b) into main (a108290) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   86.54%   86.70%   +0.16%     
==========================================
  Files          51       52       +1     
  Lines        1479     1497      +18     
  Branches      365      373       +8     
==========================================
+ Hits         1280     1298      +18     
  Misses        196      196              
  Partials        3        3              
Flag Coverage Δ
dashboards-notifications 86.70% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@zhichao-aws zhichao-aws marked this pull request as ready for review August 28, 2023 08:11
@zhichao-aws zhichao-aws added backport 2.x v2.10.0 Issues targeting release v2.10.0 labels Aug 28, 2023
@xluo-aws xluo-aws merged commit 5903c27 into opensearch-project:main Aug 28, 2023
10 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-44-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5903c2737042f8854db86634c288033223dd07f8
# Push it to GitHub
git push --set-upstream origin backport/backport-44-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-44-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x failed backport v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants