Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move create acceleration flyout from workbench to datasources #1508

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Mar 9, 2024

Description

We made a design choice to move create acceleration flyout from workbench to datasources. This was done as many components from datasource like the table, acceleration flyouts will be coming used workbench which are today present in datasources. This helps us to avoid a circular dependency between plugins.

Issues Resolved

  • Keep workbench as a plugin dependent on datasources

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 changed the title Move create acceleration from workbench to datasources Move create acceleration flyout from workbench to datasources Mar 9, 2024
@ps48 ps48 marked this pull request as ready for review March 9, 2024 18:31
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 54.93230% with 233 lines in your changes are missing coverage. Please review.

Project coverage is 56.51%. Comparing base (df7020a) to head (d2c8fdf).
Report is 1 commits behind head on main.

Files Patch % Lines
.../accelerations/selectors/index_setting_options.tsx 29.67% 64 Missing ⚠️
...manage/accelerations/selectors/source_selector.tsx 58.18% 23 Missing ⚠️
...al_editors/materialized_view/column_expression.tsx 30.00% 21 Missing ⚠️
..._editors/skipping_index/skipping_index_builder.tsx 52.27% 21 Missing ⚠️
...l_editors/materialized_view/add_column_popover.tsx 43.33% 17 Missing ⚠️
...s/materialized_view/group_by_tumble_expression.tsx 38.46% 16 Missing ⚠️
..._editors/covering_index/covering_index_builder.tsx 42.10% 11 Missing ⚠️
...visual_editors/skipping_index/add_fields_modal.tsx 35.29% 11 Missing ⚠️
...age/accelerations/visual_editors/query_builder.tsx 82.00% 9 Missing ⚠️
...s/components/manage/accelerations/create/utils.tsx 85.96% 8 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1508      +/-   ##
==========================================
- Coverage   56.58%   56.51%   -0.07%     
==========================================
  Files         331      348      +17     
  Lines       12138    12655     +517     
  Branches     3119     3205      +86     
==========================================
+ Hits         6868     7152     +284     
- Misses       5216     5449     +233     
  Partials       54       54              
Flag Coverage Δ
dashboards-observability 56.51% <54.93%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit ab7d9fd into opensearch-project:main Mar 9, 2024
14 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 9, 2024
* move create acceleration to datasources

Signed-off-by: Shenoy Pratik <[email protected]>

* update tests and snapshots

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit ab7d9fd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 9, 2024
…#1510)

* move create acceleration to datasources



* update tests and snapshots



---------


(cherry picked from commit ab7d9fd)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…search-project#1482) (opensearch-project#1508)

* filter high level groups and action groups by cluster and index

Signed-off-by: Derek Ho <[email protected]>

* remove unecessary console

Signed-off-by: Derek Ho <[email protected]>

* add semicolon back

Signed-off-by: Derek Ho <[email protected]>

* use map instead of flat map

Signed-off-by: Derek Ho <[email protected]>

* fix lint

Signed-off-by: Derek Ho <[email protected]>

* fix tests

Signed-off-by: Derek Ho <[email protected]>

* revert file

Signed-off-by: Derek Ho <[email protected]>

* fix up tests

Signed-off-by: Derek Ho <[email protected]>

* lint

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 5fd80182d825425669e7e06ca9ea976ffa431f42)

Co-authored-by: Derek Ho <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…arch-project#1508) (opensearch-project#1510)

* move create acceleration to datasources

* update tests and snapshots

---------

(cherry picked from commit ab7d9fd)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 5bb1ae7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants