-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move create acceleration flyout from workbench to datasources #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
changed the title
Move create acceleration from workbench to datasources
Move create acceleration flyout from workbench to datasources
Mar 9, 2024
ps48
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
March 9, 2024 18:31
Swiddis
approved these changes
Mar 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
- Coverage 56.58% 56.51% -0.07%
==========================================
Files 331 348 +17
Lines 12138 12655 +517
Branches 3119 3205 +86
==========================================
+ Hits 6868 7152 +284
- Misses 5216 5449 +233
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mengweieric
approved these changes
Mar 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 9, 2024
* move create acceleration to datasources Signed-off-by: Shenoy Pratik <[email protected]> * update tests and snapshots Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit ab7d9fd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Mar 9, 2024
…#1510) * move create acceleration to datasources * update tests and snapshots --------- (cherry picked from commit ab7d9fd) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Mar 9, 2024
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…search-project#1482) (opensearch-project#1508) * filter high level groups and action groups by cluster and index Signed-off-by: Derek Ho <[email protected]> * remove unecessary console Signed-off-by: Derek Ho <[email protected]> * add semicolon back Signed-off-by: Derek Ho <[email protected]> * use map instead of flat map Signed-off-by: Derek Ho <[email protected]> * fix lint Signed-off-by: Derek Ho <[email protected]> * fix tests Signed-off-by: Derek Ho <[email protected]> * revert file Signed-off-by: Derek Ho <[email protected]> * fix up tests Signed-off-by: Derek Ho <[email protected]> * lint Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 5fd80182d825425669e7e06ca9ea976ffa431f42) Co-authored-by: Derek Ho <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…arch-project#1508) (opensearch-project#1510) * move create acceleration to datasources * update tests and snapshots --------- (cherry picked from commit ab7d9fd) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 5bb1ae7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We made a design choice to move create acceleration flyout from workbench to datasources. This was done as many components from datasource like the table, acceleration flyouts will be coming used workbench which are today present in datasources. This helps us to avoid a circular dependency between plugins.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.