[Feature] Auto trigger schema setup in assets creation flow of get started page #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TackAdam
reviewed
Oct 11, 2024
| }); | ||
|
|
||
| if (checkedCollector !== undefined) { | ||
| if (checkedCollector.value === 'otel') { |
There was a problem hiding this comment.
My PR adjust the otel value to be broken into the three different paths 'otelLogs' , 'otelMetrics' and 'otelTraces' which will all have slightly different templates to push.
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric <[email protected]>
mengweieric
force-pushed
the
feature/auto-trigger-schema-setup
branch
from
0c9a3ca
to
dc1bc56
Compare
Signed-off-by: Eric <[email protected]>
TackAdam
reviewed
Oct 14, 2024
public/components/getting_started/components/getting_started_collectData.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
TackAdam
approved these changes
Oct 14, 2024
ps48
approved these changes
Oct 14, 2024
|
can you please look at failing snapshots? |
| // Auto-generate index templates based on the selected integration | ||
| let templates: ICollectorIndexTemplate[] = []; | ||
| if (curIntegration !== undefined) { | ||
| const indexTemplateMappings = await http!.get( |
There was a problem hiding this comment.
Are we making this call on every selection or only once? we can cache this right.
There was a problem hiding this comment.
yes this is actually what I was considering also for an improvement later, but this is only triggered per 'create assets' button clicked, simply clicking on different cards won't trigger this call
Signed-off-by: Eric <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
…arted page (#2200) * updated release notes (#1997) Signed-off-by: sumukhswamy <[email protected]> * updated release notes (#1997) Signed-off-by: sumukhswamy <[email protected]> * add template creation to assests creation flow Signed-off-by: Eric <[email protected]> * adopt recent UI changes for the same flow Signed-off-by: Eric <[email protected]> * fix lint issue Signed-off-by: Eric <[email protected]> * add types Signed-off-by: Eric <[email protected]> * update snapshots Signed-off-by: Eric <[email protected]> * fix default selection between metrics / traces Signed-off-by: Adam Tackett <[email protected]> * update snapshots Signed-off-by: Eric <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Eric <[email protected]> Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Sumukh Swamy <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 3939809) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
pushed a commit
that referenced
this pull request
Oct 15, 2024
…arted page (#2200) (#2203) * updated release notes (#1997) * updated release notes (#1997) * add template creation to assests creation flow * adopt recent UI changes for the same flow * fix lint issue * add types * update snapshots * fix default selection between metrics / traces * update snapshots --------- (cherry picked from commit 3939809) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Eric <[email protected]> Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sumukh Swamy <[email protected]> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding index template creation to existing observability assets creation flow.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.