Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Auto trigger schema setup in assets creation flow of get started page #2200
[Feature] Auto trigger schema setup in assets creation flow of get started page #2200
Changes from 5 commits
dd6ec85
494e324
1fe9efe
dc1bc56
c084206
d898b17
cd9f806
2b91663
5cd18d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 68 in public/components/getting_started/components/getting_started_collectData.tsx
GitHub Actions / Lint
Check warning on line 71 in public/components/getting_started/components/getting_started_collectData.tsx
GitHub Actions / Lint
Check warning on line 73 in public/components/getting_started/components/getting_started_collectData.tsx
GitHub Actions / Lint
Check warning on line 78 in public/components/getting_started/components/getting_started_collectData.tsx
GitHub Actions / Lint
Check warning on line 128 in public/components/getting_started/components/getting_started_collectData.tsx
GitHub Actions / Lint
Check warning on line 130 in public/components/getting_started/components/getting_started_collectData.tsx
GitHub Actions / Lint
Check warning on line 149 in public/components/getting_started/components/getting_started_collectData.tsx
GitHub Actions / Lint
Check warning on line 223 in public/components/getting_started/components/getting_started_collectData.tsx
GitHub Actions / Lint
Check warning on line 271 in public/components/getting_started/components/getting_started_collectData.tsx
GitHub Actions / Lint
Check warning on line 296 in public/components/getting_started/components/getting_started_collectData.tsx
GitHub Actions / Lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we making this call on every selection or only once? we can cache this right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this is actually what I was considering also for an improvement later, but this is only triggered per 'create assets' button clicked, simply clicking on different cards won't trigger this call