[Alerting 2.10] Excluding flaky tests #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
kavilla
reviewed
Sep 20, 2023
| @@ -66,7 +66,7 @@ describe('CompositeLevelMonitor', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('by visual editor', () => { | |||
| xit('by visual editor', () => { | |||
There was a problem hiding this comment.
does x work? shouldn't be it.skip?
can also do something similar and conditional run these tests if its only flaky on with-security. Then can still verify on without-security
regardless, if you can make a follow up issue that would be great. thank you
There was a problem hiding this comment.
Yes x also works on excluding these tests. Given that these tests are passing locally, and we are nearing the 2.10 deadline, I'm okay with excluding them from the CI pipeline run
kavilla
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Excluding flaky tests for composite monitors
Issues Resolved
opensearch-project/alerting-dashboards-plugin#737
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.