Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting 2.10] Excluding flaky tests #886

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[Alerting 2.10] Excluding flaky tests #886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cypress/integration/plugins/alerting-dashboards-plugin/composite_level_monitor_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe('CompositeLevelMonitor', () => {
});
});

it('by visual editor', () => {
xit('by visual editor', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does x work? shouldn't be it.skip?

can also do something similar and conditional run these tests if its only flaky on with-security. Then can still verify on without-security

regardless, if you can make a follow up issue that would be great. thank you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes x also works on excluding these tests. Given that these tests are passing locally, and we are nearing the 2.10 deadline, I'm okay with excluding them from the CI pipeline run

// Select visual editor for method of definition
cy.get('[data-test-subj="visualEditorRadioCard"]').click({ force: true });

Expand Down Expand Up @@ -154,7 +154,7 @@ describe('CompositeLevelMonitor', () => {
});
});

it('by visual editor', () => {
xit('by visual editor', () => {
// Verify edit page
cy.contains('Edit monitor', { timeout: 20000 });
cy.get('input[name="name"]').type('_edited');
Expand Down
Loading