-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functional test for datasources at observability dashboards plugin #987
Add functional test for datasources at observability dashboards plugin #987
Conversation
Facing the errors of OS set up step in observability e2e workflow (https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/7402681376/job/20141042426?pr=987#step:6:13289):
|
Will be unblocked when #981 is merged |
Signed-off-by: Ryan Liang <[email protected]>
30b0fad
to
9df862e
Compare
Signed-off-by: Ryan Liang <[email protected]>
The observability workflow is stucking there for 4+ hrs (See log: https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/7506009472/job/20436491850?pr=987). According to the above, I have run my code change on my local and here are the results: Recorded video in browser: 7_datasources_dashboard.spec.js.mp4(cc. @Hailong-am , @ruanyl , @wanglam ) |
Signed-off-by: Ryan Liang <[email protected]>
For now we recommend you post the test result in your local env as a workaround. |
#987) * Add functional test for datasources at observability dashboards plugin Signed-off-by: Ryan Liang <[email protected]> * Extend the header locating to 2 mins Signed-off-by: Ryan Liang <[email protected]> * Fix lint Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 8cd68dc)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-987-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8cd68dc509eeb01ca7658f1f784201ce117cf009
# Push it to GitHub
git push --set-upstream origin backport/backport-987-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
opensearch-project#987) * Add functional test for datasources at observability dashboards plugin Signed-off-by: Ryan Liang <[email protected]> * Extend the header locating to 2 mins Signed-off-by: Ryan Liang <[email protected]> * Fix lint Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
…ashboards plugin (#1024) * Add functional test for datasources at observability dashboards plugin (#987) * Add functional test for datasources at observability dashboards plugin Signed-off-by: Ryan Liang <[email protected]> * Extend the header locating to 2 mins Signed-off-by: Ryan Liang <[email protected]> * Fix lint Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]> * Change the assertions check for urls Signed-off-by: Ryan Liang <[email protected]> * Fix lint Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]> Co-authored-by: Hailong Cui <[email protected]>
Description
Add functional test for datasources at observability dashboards plugin
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.