Security Roles and Audit Log Settings follow Dashboard themes #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
cwperks
commented
Aug 18, 2023
| @@ -5,7 +5,3 @@ | |||
| .form-row { | |||
| max-width: 800px; | |||
| } | |||
|
|
|||
| pre code { | |||
There was a problem hiding this comment.
Before:
After:
This is on Security -> Audit Logs -> Compliance Settings (Configure)
This could use a more subdued color, but I thought it would be reasonable to remove and use the colors shipped with EuiCodeEditor.
cwperks
commented
Aug 18, 2023
| @@ -14,7 +14,7 @@ | |||
| */ | |||
|
|
|||
| .panel-header-count { | |||
| color: #687078; | |||
| color: $euiTextSubduedColor; | |||
There was a problem hiding this comment.
Before:
After:
This affects the number in paren next to the config type. In this case Roles **(42)**. This class is re-used on a few panels.
Codecov Report
@@ Coverage Diff @@
## main #1558 +/- ##
=======================================
Coverage 66.06% 66.06%
=======================================
Files 93 93
Lines 2328 2328
Branches 310 310
=======================================
Hits 1538 1538
Misses 722 722
Partials 68 68 |
3 tasks
|
@kamingleung Could you review this small security-dashboards-plugin PR to remove 2 instances of hardcoded colors? |
stephen-crawford
approved these changes
Aug 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit c10031f)
cwperks
added a commit
that referenced
this pull request
Aug 22, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit c10031f) Co-authored-by: Craig Perkins <[email protected]>
peternied
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are 2 instances in this repo of hardcoded colors:
This PR either updates or removes the instance of the hardcoded color to comply with #1471
Category
Maintenance
Issues Resolved
#1471
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.