Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Roles and Audit Log Settings follow Dashboard themes #1558

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Security Roles and Audit Log Settings follow Dashboard themes #1558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/apps/configuration/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*/

.panel-header-count {
color: #687078;
color: $euiTextSubduedColor;
Copy link
Member Author

@cwperks cwperks Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

Screenshot 2023-08-18 at 1 47 52 PM

After:

Screenshot 2023-08-18 at 1 52 03 PM

This affects the number in paren next to the config type. In this case Roles **(42)**. This class is re-used on a few panels.

font-weight: normal;
}

Expand Down
4 changes: 0 additions & 4 deletions public/apps/configuration/panels/audit-logging/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,3 @@
.form-row {
max-width: 800px;
}

pre code {
Copy link
Member Author

@cwperks cwperks Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

Screenshot 2023-08-18 at 1 45 40 PM

After:

Screenshot 2023-08-18 at 1 45 52 PM

This is on Security -> Audit Logs -> Compliance Settings (Configure)

This could use a more subdued color, but I thought it would be reasonable to remove and use the colors shipped with EuiCodeEditor.

color: #666;
}
Loading