-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serverless-1.34] Set default value for REGISTRY param on func-s2i task [SRVOCF-628] #922
[serverless-1.34] Set default value for REGISTRY param on func-s2i task [SRVOCF-628] #922
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## serverless-1.34 #922 +/- ##
==================================================
Coverage ? 66.65%
==================================================
Files ? 129
Lines ? 11936
Branches ? 0
==================================================
Hits ? 7956
Misses ? 3018
Partials ? 962
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, jrangelramos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
25c6d78
into
openshift-knative:serverless-1.34
* Create test symlinks dynamically Some tools dislike having questionable symlinks in git repository so we must create this symlinks dynamically in the test instead of having it committed into the repository. Signed-off-by: Matej Vašek <[email protected]> * fix: Remove unnecesary annotations from Pipeline-as-Code template (#917) * Set default value for REGISTRY param on func-s2i task (#922) * fixup: fix size/hash of socat rpm Signed-off-by: Matej Vašek <[email protected]> * Fix test failures in OCP prow CI Ensure that ServeRepo() make copy of repo from ./testdata and serves the repo from that copy. Signed-off-by: Matej Vašek <[email protected]> --------- Signed-off-by: Matej Vašek <[email protected]> --------- Signed-off-by: Matej Vašek <[email protected]> Co-authored-by: Jefferson Ramos <[email protected]>
No description provided.