-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-47627: dnsmasq service on OCP SNO fails to read /etc/resolv.conf file during system startup #7247
OCPBUGS-47627: dnsmasq service on OCP SNO fails to read /etc/resolv.conf file during system startup #7247
Conversation
…onf file during system startup network.target doesn't garantee that interfaces are configured (https://systemd.io/NETWORK_ONLINE/), so we may have cases were dnsmasq fails to start because `resolv.conf` is not there yet. This fix will start dnsmasq after `ovs-configuration` service so we are sure that the network is configured at this point.
Skipping CI for Draft Pull Request. |
@adriengentil: This pull request references Jira Issue OCPBUGS-47627, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test ? |
@adriengentil: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test edge-e2e-metal-assisted-sno-4-18 |
2 similar comments
/test edge-e2e-metal-assisted-sno-4-18 |
/test edge-e2e-metal-assisted-sno-4-18 |
/cc @tsorya |
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7247 +/- ##
==========================================
+ Coverage 67.89% 68.24% +0.34%
==========================================
Files 298 300 +2
Lines 40711 41296 +585
==========================================
+ Hits 27642 28181 +539
- Misses 10592 10621 +29
- Partials 2477 2494 +17
|
/jira refresh |
@adriengentil: This pull request references Jira Issue OCPBUGS-47627, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.18 release-4.17 release-4.16 |
@adriengentil: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
1 similar comment
/retest |
@adriengentil: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
aa1aeec
into
openshift:master
@adriengentil: Jira Issue OCPBUGS-47627: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-47627 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@adriengentil: new pull request created: #7257 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-api-server |
network.target doesn't garantee that interfaces are configured
(https://systemd.io/NETWORK_ONLINE/), so we may have cases were dnsmasq
fails to start because
resolv.conf
is not there yet.This fix will start dnsmasq after
ovs-configuration
service so we aresure that the network is configured at this point.