Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] OCPBUGS-49743: dnsmasq service on OCP SNO fails to read /etc/resolv.conf file during system startup #7257

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] OCPBUGS-49743: dnsmasq service on OCP SNO fails to read /etc/resolv.conf file during system startup #7257

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #7247

/assign adriengentil

/cherrypick release-4.17 release-4.16

@adriengentil
OCPBUGS-47627: dnsmasq service on OCP SNO fails to read /etc/resolv.c…
9f26655 
…onf file during system startup

network.target doesn't garantee that interfaces are configured
(https://systemd.io/NETWORK_ONLINE/), so we may have cases were dnsmasq
fails to start because `resolv.conf` is not there yet.

This fix will start dnsmasq after `ovs-configuration` service so we are
sure that the network is configured at this point.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 2, 2025
Merged
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-47627 has been cloned as Jira Issue OCPBUGS-49743. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-49743: dnsmasq service on OCP SNO fails to read /etc/resolv.conf file during system startup

In response to this:

This is an automated cherry-pick of #7247

/assign adriengentil

/cherrypick release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-47627: dnsmasq service on OCP SNO fails to read /etc/resolv.conf file during system startup [release-4.18] OCPBUGS-49743: dnsmasq service on OCP SNO fails to read /etc/resolv.conf file during system startup Feb 2, 2025
@openshift-ci openshift-ci bot requested review from avishayt and mlorenzofr February 2, 2025 00:16
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 2, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-49743, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #7247

/assign adriengentil

/cherrypick release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 2, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mlorenzofr
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamli75 gamli75 gamli75 approved these changes

@avishayt avishayt Awaiting requested review from avishayt

@mlorenzofr mlorenzofr Awaiting requested review from mlorenzofr

Assignees

@adriengentil adriengentil

@mlorenzofr mlorenzofr

@gamli75 gamli75

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @mlorenzofr @gamli75 @adriengentil