Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-13341: Use assisted service client wheel #1999

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

adriengentil
Copy link
Contributor

@adriengentil adriengentil commented Jan 17, 2023

Currently, the sdist version fails to install because of an update of
setuptools: pypa/setuptools#3772.

The wheel is not affected by this change.

Depending on the outcome of the setuptools ticket, we may have to
follow-up to provide a valid version scheme for the sdist package (or
just remove it?).

Currently, the sdist version fails to install because of an update of
setuptools: pypa/setuptools#3772.

The wheel is not affected by this change.

Depending on the output of the setuptools ticket, we may have to
follow-up to provide a valid version scheme for the sdist package.
@openshift-ci openshift-ci bot requested review from eranco74 and tsorya January 17, 2023 11:05
@adriengentil
Copy link
Contributor Author

/cc @osherdp @eliorerz

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2023
@openshift-ci openshift-ci bot requested review from eliorerz and osherdp January 17, 2023 11:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adriengentil,osherdp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriengentil
Copy link
Contributor Author

/cherry-pick release-ocm-2.7

@openshift-cherrypick-robot

@adriengentil: once the present PR merges, I will cherry-pick it on top of release-ocm-2.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-ocm-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriengentil
Copy link
Contributor Author

/test e2e-metal-assisted-kube-api-late-binding-single-node

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b94ba99 and 2 for PR HEAD f04d7d2 in total

@adriengentil
Copy link
Contributor Author

/retest

@adriengentil
Copy link
Contributor Author

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node ci/prow/e2e-metal-assisted-kube-api-net-suite ci/prow/e2e-metal-single-node-live-iso

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2023

@adriengentil: Overrode contexts on behalf of adriengentil: ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node, ci/prow/e2e-metal-assisted-kube-api-net-suite, ci/prow/e2e-metal-single-node-live-iso

In response to this:

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node ci/prow/e2e-metal-assisted-kube-api-net-suite ci/prow/e2e-metal-single-node-live-iso

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 13fc0ae and 1 for PR HEAD f04d7d2 in total

@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2023

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot

@adriengentil: new pull request created: #2003

In response to this:

/cherry-pick release-ocm-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants