Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43920: operator: remove duplicate kube client #1361

Merged
merged 1 commit into from
Oct 30, 2024
Merged

OCPBUGS-43920: operator: remove duplicate kube client #1361

merged 1 commit into from
Oct 30, 2024

Conversation

vrutkovs
Copy link
Member

This one is using JSON instead of protobuf

@vrutkovs
operator: remove duplicate kube client
c1a8bd3 
This one is using JSON instead of protobuf
@vrutkovs vrutkovs mentioned this pull request Oct 25, 2024
Draft
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b4572c50-92c1-11ef-9dc8-8ee5ecca121f-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/31391bc0-92ef-11ef-8a0e-563ed35e32a0-0

@tjungblu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tjungblu, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@vrutkovs vrutkovs changed the title NO-JIRA operator: remove duplicate kube client OCPBUGS-43920: operator: remove duplicate kube client Oct 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2024
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-43920, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This one is using JSON instead of protobuf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 29, 2024
@openshift-ci openshift-ci bot requested a review from geliu2016 October 29, 2024 10:57
@vrutkovs
Copy link
Member Author

/test unit

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 26e5aee and 2 for PR HEAD c1a8bd3 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 26e5aee and 2 for PR HEAD c1a8bd3 in total

@vrutkovs vrutkovs mentioned this pull request Oct 29, 2024
Draft
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fd0725a0-960d-11ef-9b20-c6c69022f342-0

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 26e5aee and 2 for PR HEAD c1a8bd3 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 29, 2024 •
edited
Loading

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery c1a8bd3 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-etcd-certrotation c1a8bd3 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown c1a8bd3 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown c1a8bd3 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tjungblu
Copy link
Contributor

/override ci/prow/e2e-aws-ovn-etcd-scaling

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-etcd-scaling

In response to this:

/override ci/prow/e2e-aws-ovn-etcd-scaling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ffa2c08 into openshift:master Oct 30, 2024
13 of 17 checks passed
@openshift-ci-robot
Copy link

@vrutkovs: Jira Issue OCPBUGS-43920: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43920 has been moved to the MODIFIED state.

In response to this:

This one is using JSON instead of protobuf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator
This PR has been included in build cluster-etcd-operator-container-v4.18.0-202410300911.p0.gffa2c08.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusk125 dusk125 Awaiting requested review from dusk125

@Elbehery Elbehery Awaiting requested review from Elbehery

@geliu2016 geliu2016 Awaiting requested review from geliu2016

Assignees

@tjungblu tjungblu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vrutkovs @tjungblu @openshift-ci-robot @openshift-bot