Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several request/response headers in audit log entries #2121

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vrutkovs
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 22, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
Copy link

openshift-ci bot commented Oct 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

@vrutkovs: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Oct 22, 2024
Copy link

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn-serial

@vrutkovs
Copy link
Member Author

/payload-job-with-prs openshift/origin#29222 periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

Copy link

openshift-ci bot commented Oct 23, 2024

@vrutkovs: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@vrutkovs
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial openshift/origin#29222

Copy link

openshift-ci bot commented Oct 23, 2024

@vrutkovs: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@vrutkovs
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial https://github.com/openshift/origin/pull/29222,openshift/kubernetes#2121,openshift/cluster-monitoring-operator#2505

Copy link

openshift-ci bot commented Oct 23, 2024

@vrutkovs: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@vrutkovs
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial openshift/origin/pull/29222 #2121 openshift/cluster-monitoring-operator#2505

Copy link

openshift-ci bot commented Oct 23, 2024

@vrutkovs: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message. unable to get additional pr info from string: openshift/origin/pull/29222: string: openshift/origin/pull/29222 doesn't match expected format: org/repo#number

Please contact an administrator to resolve this issue.

@vrutkovs
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial https://github.com/openshift/origin#29222 #2121 openshift/cluster-monitoring-operator#2505

Copy link

openshift-ci bot commented Oct 23, 2024

@vrutkovs: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@vrutkovs
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial openshift/origin#29222 #2121 openshift/cluster-monitoring-operator#2505

Copy link

openshift-ci bot commented Oct 23, 2024

@vrutkovs: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8ead4490-9117-11ef-8662-fdd14cd693cb-0

Copy link

openshift-ci bot commented Oct 23, 2024

@vrutkovs: This PR was included in a payload test run from #2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8ead4490-9117-11ef-8662-fdd14cd693cb-0

@vrutkovs
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial https://github.com/openshift/origin#29222 https://github.com/openshift/kubernetes#2121 https://github.com/openshift/cluster-monitoring-operator#2505 cluster-csi-snapshot-controller-operator#217 machine-config-operator#4658

Copy link

openshift-ci bot commented Oct 23, 2024

@vrutkovs: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@vrutkovs
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial openshift/origin#29222 #2121 openshift/cluster-monitoring-operator#2505 openshift/cluster-csi-snapshot-controller-operator#217 openshift/machine-config-operator#4658

Copy link

openshift-ci bot commented Oct 23, 2024

@vrutkovs: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/17dde510-911a-11ef-90f7-2ad72545de28-0

Copy link

openshift-ci bot commented Oct 23, 2024

@vrutkovs: This PR was included in a payload test run from #2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/17dde510-911a-11ef-90f7-2ad72545de28-0

Copy link

openshift-ci bot commented Oct 24, 2024

@vrutkovs: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f7b0780-91d0-11ef-801e-f8298112fd81-0

Copy link

openshift-ci bot commented Oct 24, 2024

@vrutkovs: This PR was included in a payload test run from #2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f7b0780-91d0-11ef-801e-f8298112fd81-0

@vrutkovs vrutkovs force-pushed the audit-log-request-response-headers branch from aac0963 to 762f3eb Compare October 24, 2024 10:00
@openshift-ci-robot
Copy link

@vrutkovs: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn-serial

@vrutkovs vrutkovs force-pushed the audit-log-request-response-headers branch from 762f3eb to a56a987 Compare October 24, 2024 11:56
@openshift-ci-robot
Copy link

@vrutkovs: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@vrutkovs vrutkovs force-pushed the audit-log-request-response-headers branch from a56a987 to 1cf4aa6 Compare October 24, 2024 11:56
@openshift-ci-robot
Copy link

@vrutkovs: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn-serial

Copy link

openshift-ci bot commented Oct 24, 2024

@vrutkovs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial 1cf4aa6 link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial openshift/origin#29222 #2121 openshift/cluster-monitoring-operator#2505 cluster-csi-snapshot-controller-operator#217 openshift/machine-config-operator#4658

Copy link

openshift-ci bot commented Oct 25, 2024

@vrutkovs: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message. unable to get additional pr info from string: cluster-csi-snapshot-controller-operator#217: string: cluster-csi-snapshot-controller-operator#217 doesn't match expected format: org/repo#number

Please contact an administrator to resolve this issue.

@vrutkovs vrutkovs force-pushed the audit-log-request-response-headers branch from 1cf4aa6 to 26df186 Compare October 25, 2024 09:34
@openshift-ci-robot
Copy link

@vrutkovs: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@vrutkovs
Copy link
Member Author

Copy link

openshift-ci bot commented Oct 25, 2024

@vrutkovs: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b4572c50-92c1-11ef-9dc8-8ee5ecca121f-0

Copy link

openshift-ci bot commented Oct 25, 2024

@vrutkovs: This PR was included in a payload test run from #2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b4572c50-92c1-11ef-9dc8-8ee5ecca121f-0

@vrutkovs
Copy link
Member Author

Copy link

openshift-ci bot commented Oct 25, 2024

@vrutkovs: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/31391bc0-92ef-11ef-8a0e-563ed35e32a0-0

Copy link

openshift-ci bot commented Oct 25, 2024

@vrutkovs: This PR was included in a payload test run from #2121
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/31391bc0-92ef-11ef-8a0e-563ed35e32a0-0

Copy link

openshift-ci bot commented Oct 29, 2024

@vrutkovs: This PR was included in a payload test run from #2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fd0725a0-960d-11ef-9b20-c6c69022f342-0

Copy link

openshift-ci bot commented Oct 30, 2024

@vrutkovs: This PR was included in a payload test run from #2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/081fe680-96da-11ef-91f4-cde4735e474b-0

Copy link

openshift-ci bot commented Oct 30, 2024

@vrutkovs: This PR was included in a payload test run from #2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a7c78740-96f5-11ef-8917-56e896fcf5d0-0

Copy link

openshift-ci bot commented Oct 31, 2024

@vrutkovs: This PR was included in a payload test run from #2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/20169390-9790-11ef-9369-5b6a6b14fab2-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants