[WIP] Fail edpm_network_config when there are schema errors #720
Conversation
vcandapp
requested review from
Jaganathancse
and removed request for
fultonj and
fao89
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vcandapp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| file: network_config.yml | ||
| when: edpm_network_config_tool == 'os-net-config' | ||
|
|
||
| - name: Disable auto-configuration of all interfaces by NetworkManager |
There was a problem hiding this comment.
Can we change block name similar like nmstate section
'Configure network with network role from system roles [os-net-config]'
| @@ -207,7 +209,7 @@ def main(): | |||
| detailed_exit_codes = args['detailed_exit_codes'] | |||
| safe_defaults = args['safe_defaults'] | |||
| use_nmsate = args['use_nmstate'] | |||
| return_codes = [0] | |||
| return_codes = [0,1] | |||
There was a problem hiding this comment.
i think no need to add 1 here. only 0 is for success to check failed or not.
There was a problem hiding this comment.
Have removed this file now
vcandapp
force-pushed
the
osnet_updt
branch
2 times, most recently
from
5f07e56
to
a8c794e
Compare
Set no-auto-defult flag for os-net-config
|
@karthiksundaravel / @Jaganathancse , updated this PR for better tracking. This PR will have fix only for the no-auto-default. Will created a new PR for "--exit-on-validation-error" |
|
@vcandapp: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Currently when there are schema errors in os-net-config, the logs are updated and no failure happens.
Updating this behaviour so that user can fix errors and re-run role