Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fail edpm_network_config when there are schema errors #720

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[WIP] Fail edpm_network_config when there are schema errors #720

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d583166
Update edpm_network_config for no-auto-default
vcandapp Aug 5, 2024
4dffa45
Merge branch 'main' into osnet_updt
vcandapp Aug 6, 2024
0689cf7
Merge branch 'main' into osnet_updt
vcandapp Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions roles/edpm_network_config/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,25 @@
- name: Load system-roles.network tasks [nmstate]
ansible.builtin.include_role:
name: "{{ lookup('ansible.builtin.env', 'EDPM_SYSTEMROLES', default='fedora.linux_system_roles') + '.network' }}"
- name: Load edpm_network_config tasks [os-net-config]
ansible.builtin.include_tasks:
file: network_config.yml
when: edpm_network_config_tool == 'os-net-config'

- name: Disable auto-configuration of all interfaces by NetworkManager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change block name similar like nmstate section
'Configure network with network role from system roles [os-net-config]'

when: ( edpm_bootstrap_network_service == 'NetworkManager' ) and
vcandapp marked this conversation as resolved.
Show resolved Hide resolved
( edpm_network_config_tool == 'os-net-config' )
become: true
block:
- name: Set 'no-auto-default' in /etc/NetworkManager/NetworkManager.conf
community.general.ini_file:
path: /etc/NetworkManager/NetworkManager.conf
state: present
no_extra_spaces: true
section: main
option: no-auto-default
value: "*"
backup: true
- name: Restart NetworkManager
ansible.builtin.systemd:
name: NetworkManager
state: restarted
- name: Load edpm_network_config tasks for os-net-config
ansible.builtin.include_tasks:
file: network_config.yml
Loading