Skip download_cache packages tasks with bootc #875
Conversation
Signed-off-by: James Slagle <[email protected]>
| when: edpm_download_cache_packages | bool | ||
| when: | ||
| - edpm_download_cache_packages | bool | ||
| - not ansible_local.bootc |
There was a problem hiding this comment.
can you explain why this is skipped, is the intent to install all host packages differently (in the image or as an overlay) for bootc. this is just pre-downloading packages that will be installed by later roles.
so if this does not work i would expect the edpm_libvirt or edpm_ovs roles to also fail.
There was a problem hiding this comment.
We can't use a package manager in the bootc image, so all of the dependencies are built into the Container:
https://github.com/openstack-k8s-operators/edpm-image-builder/blob/main/bootc/Containerfile.centos9#L41-L57
There was a problem hiding this comment.
i see so that will need us to have containers/bootc#76
to be able to support in place upgrades and cve patching of anything in that image.
so haveing a small dep set will be important to minimise the human operator pain fo needing to live migrate instance or take the down time.
some of the packages like libguestfs should not be in the image by the way.
to be fair we haven't gotten around to removing it form edpm ansible yet
https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/roles/edpm_libvirt/defaults/main.yml#L56-L57
but we did remove it form the nova containers because we do not have any supported usecase for it so it should not be needed.
that out of scope of this but we should probably avoid cargo culting it into the new image.
https://issues.redhat.com//browse/OSPRH-192
openstack-k8s-operators/tcib@e935383#diff-20fdbc4b7badc4cdcab1a535614f5d3c52acabf84aba7661ac2e5ead8acc276eL22
the reset look fine to be fair so we probably need to remove it in yet another pr :)
it would be 4th pr to try an removal all references to libguestfs
There was a problem hiding this comment.
Sure, we can remove it.
openstack-k8s-operators/edpm-image-builder#63
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rabi, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d21db50
into
openstack-k8s-operators:bootc
Signed-off-by: James Slagle [email protected]