Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip download_cache packages tasks with bootc #875

Merged
merged 1 commit into from
Feb 14, 2025
+3 −1
Merged

Skip download_cache packages tasks with bootc #875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion roles/edpm_download_cache/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@

- name: Download packages
ansible.builtin.include_tasks: packages.yml
when: edpm_download_cache_packages | bool
when:
- edpm_download_cache_packages | bool
- not ansible_local.bootc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why this is skipped, is the intent to install all host packages differently (in the image or as an overlay) for bootc. this is just pre-downloading packages that will be installed by later roles.

so if this does not work i would expect the edpm_libvirt or edpm_ovs roles to also fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use a package manager in the bootc image, so all of the dependencies are built into the Container:
https://github.com/openstack-k8s-operators/edpm-image-builder/blob/main/bootc/Containerfile.centos9#L41-L57

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see so that will need us to have containers/bootc#76
to be able to support in place upgrades and cve patching of anything in that image.

so haveing a small dep set will be important to minimise the human operator pain fo needing to live migrate instance or take the down time.

some of the packages like libguestfs should not be in the image by the way.

to be fair we haven't gotten around to removing it form edpm ansible yet

https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/roles/edpm_libvirt/defaults/main.yml#L56-L57
but we did remove it form the nova containers because we do not have any supported usecase for it so it should not be needed.

that out of scope of this but we should probably avoid cargo culting it into the new image.

https://issues.redhat.com//browse/OSPRH-192
openstack-k8s-operators/tcib@e935383#diff-20fdbc4b7badc4cdcab1a535614f5d3c52acabf84aba7661ac2e5ead8acc276eL22

the reset look fine to be fair so we probably need to remove it in yet another pr :)

it would be 4th pr to try an removal all references to libguestfs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can remove it.
openstack-k8s-operators/edpm-image-builder#63


- name: Download container images
ansible.builtin.include_tasks: container_images.yml
Expand Down