ensure nova-operator is always required #868
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change ensures that if we trigger a job without a chagne to the nova operator repo via upstream nova that we include it as a required project so that the meta content provider will include the nova operator image.
SeanMooney
force-pushed
the
nova-trigger
branch
from
1d09506
to
c8eb714
Compare
| # when run from nova we need to ensure we list the nova-operator | ||
| # so that it will be built by the meta content provider | ||
| required-projects: | ||
| - github.com/openstack-k8s-operators/nova-operator |
There was a problem hiding this comment.
for context when we trigger a job form nova with a depends on it appears to work
but if we don't have a depend on against this repo and trigger it it fails in a way that
makes me think its because we don't actually build the correct images.
this is an attempt to fix that
the problem is i don't think we can test that without merging this.
the other way i could do this is to move the require projects to the definition of the jobs however that would require me to inherit form openstack-meta-content-provider
and add a nova-meta-content-provider with the required-project to make that work
so while i prefer to avoid creating job variants in templates i think this is the cleanest way to do this today
This change ensures that if we trigger a job without a chagne to the
nova operator repo via upstream nova that we include it as a
required project so that the meta content provider will include
the nova operator image.