Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure nova-operator is always required #868

Merged
merged 1 commit into from
Oct 3, 2024
+8 −0
Merged

ensure nova-operator is always required #868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .zuul.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,20 @@
jobs:
- openstack-meta-content-provider:
override-checkout: main
# when run from nova we need to ensure we list the nova-operator
# so that it will be built by the meta content provider
required-projects:
- github.com/openstack-k8s-operators/nova-operator
vars:
cifmw_bop_openstack_release: master
cifmw_bop_dlrn_baseurl: "https://trunk.rdoproject.org/centos9-master"
cifmw_repo_setup_branch: master
- nova-operator-tempest-multinode: &job_vars
override-checkout: main
# when run from nova we need to ensure we list the nova-operator
# so that it will be built by the meta content provider
required-projects:
- github.com/openstack-k8s-operators/nova-operator
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for context when we trigger a job form nova with a depends on it appears to work
but if we don't have a depend on against this repo and trigger it it fails in a way that
makes me think its because we don't actually build the correct images.

this is an attempt to fix that

the problem is i don't think we can test that without merging this.

the other way i could do this is to move the require projects to the definition of the jobs however that would require me to inherit form openstack-meta-content-provider
and add a nova-meta-content-provider with the required-project to make that work

so while i prefer to avoid creating job variants in templates i think this is the cleanest way to do this today

vars:
cifmw_repo_setup_branch: master
- nova-operator-tempest-multinode-ceph: *job_vars
Expand Down
Loading