fix: quests from version 12 revised #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestyotbr
changed the title
htc16
force-pushed
the
fix-quests-from-version-12-revised
branch
from
55e173f to
276c406
Compare
I stopped at "The Seven Keys".
It's not perfect, just the inclusion of some bosses that weren't on the server, and it lacks more details about the quest itself and more mechanics.
You need to review the answers, as I couldn't find them on the internet.
htc16
force-pushed
the
fix-quests-from-version-12-revised
branch
from
1a4617b to
04053f3
Compare
|
|
This PR is stale because it has been open 45 days with no activity. |
|
|
Updated global map: |
majestyotbr
approved these changes
Jan 9, 2025
vllworldbuilding
pushed a commit
to vllworldbuilding/canary
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm currently working on adding all quests to the PR. Given the large number of quests, I would like to ask for your help and collaboration to close this PR as quickly as possible. If you are interested in helping, choose one of the quests to review, open a PR for it, and link to this PR. All help is welcome!
Note1: my focus is on quests, therefore, the quest log for a quest may be missing as this is not shown in the quest tutorial lists. I study tutorials and release fix ones or develop something related to the tutorial.
Note2: I have limitations as this is the first time I am willing to do this, so please consider that some codes may not be the best but what matters is the intention and this can be improved in the future if someone finds it appropriate to do so.
Note3: I'm taking the opportunity to catalog all the aids and uids so that we can eventually modify and change them in the future directly through the script.
Note4: this PR needs some updates to the map that were reported above.
Note5: I was unable to place the writings in the books, only through the map editor, but this did not influence the development of the quest, so I left this for a future review.
Behavior
Real
I reviewed and corrected any quests that weren't working.
Delete options that are not relevant.
How this was tested
As I reviewed and modified the codes, I tested them.
Test Setup:
Checklist