Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure isPodium check works correctly #3221

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

omarcopires
Copy link
Contributor

Description

The isPodium function was not properly registered in the ItemType class, causing an error when called.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

sonarqubecloud bot commented Jan 7, 2025

@majestyotbr majestyotbr merged commit f253373 into opentibiabr:main Jan 7, 2025
24 checks passed
@omarcopires omarcopires deleted the item-validation branch January 9, 2025 01:18
vllworldbuilding pushed a commit to vllworldbuilding/canary that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants