Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add morguthis wall action #3226

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Conversation

kaleohanopahala
Copy link
Contributor

@kaleohanopahala kaleohanopahala commented Jan 8, 2025

Now you can open and close the wall -> 33211, 32698, 13
Any creatures (players or monsters) standing in the wall's position are teleported one tile south.
Any items in the wall's position are moved one tile south.

In the original game, a teleport effect is not created; however, in the Canary server, it is.
I believe there is some configuration behind this, as the script does not create a CONST_ME_TELEPORT.

@GuiValladao
Copy link
Contributor

U can add aid without any map changes using:

data-otservbr-global/startup/tables/item.lua

Take a look, test it and update your pr.

@majestyotbr majestyotbr changed the title Morguthis wall action feat: add morguthis wall action Jan 8, 2025
@Solkrasm
Copy link

Solkrasm commented Jan 8, 2025

To be honest, nothing that was mentioned makes a technical difference; the script is functional and can be merged without any issues.

@majestyotbr
Copy link
Contributor

To be honest, nothing that was mentioned makes a technical difference; the script is functional and can be merged without any issues.

It is to follow the repo pattern.

@Solkrasm
Copy link

Solkrasm commented Jan 8, 2025

U can add aid without any map changes using:

data-otservbr-global/startup/tables/item.lua

Take a look, test it and update your pr.

Yes, her Lua script reference is probably from TFS; they still use this style.
This direct method is better and avoids changes to the map.

@kaleohanopahala
Copy link
Contributor Author

To be honest, nothing that was mentioned makes a technical difference; the script is functional and can be merged without any issues.

Good morning, theres no problem.

Copy link

sonarqubecloud bot commented Jan 8, 2025

@majestyotbr majestyotbr merged commit 7c10e50 into opentibiabr:main Jan 8, 2025
19 checks passed
@kaleohanopahala kaleohanopahala deleted the tomb branch January 8, 2025 21:18
vllworldbuilding pushed a commit to vllworldbuilding/canary that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants