Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Remove unnecessary generic in MemoryReadAuxCols #1215

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[chore] Remove unnecessary generic in MemoryReadAuxCols #1215

merged 1 commit into from
Jan 14, 2025

Conversation

nyunyunyunyu
Copy link
Contributor

N is not used anymore in MemoryReadAuxCols<F, N>

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@nyunyunyunyu nyunyunyunyu force-pushed the chore/remove-unnecessary-params branch from 80c3344 to 974a24e Compare January 14, 2025 10:23
@nyunyunyunyu nyunyunyunyu merged commit 3b60c66 into main Jan 14, 2025
17 checks passed
@nyunyunyunyu nyunyunyunyu deleted the chore/remove-unnecessary-params branch January 14, 2025 10:23
@github-actions GitHub Actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+26 [+0.7%]) 3,506 711,495 25,513,055 - - -
fibonacci_program (+53 [+0.9%]) 6,115 1,500,137 51,505,102 - - -
regex_program (+88 [+0.5%]) 19,085 4,190,904 165,028,173 - - -
ecrecover_program (-30 [-1.1%]) 2,608 285,401 15,092,297 - - -

Commit: 974a24e

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yi-sun yi-sun yi-sun approved these changes

@zlangley zlangley Awaiting requested review from zlangley

@jonathanpwang jonathanpwang Awaiting requested review from jonathanpwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyunyunyunyu @yi-sun