pc: Fix Azure NFS test #17782
Closed
pc: Fix Azure NFS test #17782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobranco777
requested review from
pdostal,
grisu48 and
asmorodskyi
as code owners
grisu48
requested changes
Sep 15, 2023
| @@ -168,10 +168,6 @@ resource "azurerm_storage_account_network_rules" "openqa-group" { | |||
| virtual_network_subnet_ids = [azurerm_subnet.openqa-subnet.id] | |||
| // AZURE LIMITATION: After setting Deny, we need to allow this host otherwise we cannot do changes or delete the resources | |||
| ip_rules = [chomp(data.http.myip.response_body)] | |||
|
|
|||
| private_link_access { | |||
| endpoint_resource_id = azurerm_subnet.openqa-subnet.id | |||
There was a problem hiding this comment.
We need to check if this is really not required. I remember that when using NFS there are some network one restrictions. Let's make a VR that shows it works.
There was a problem hiding this comment.
Marking it as "requesting changes" because this has the potential to break test runs (in a different way).
A valid VR is enough to resolve this
There was a problem hiding this comment.
+1 to what Felix said . it looks weird to me that we removing something I would expect that some property changed format due to not backward-compatible changes but not something like that . Anyway if you will provide passed VR AND some brief explanations why this is suppose to be a fix I will add +1
This reverts commit b36c7fb.
ricardobranco777
force-pushed
the
fix_nfs
branch
from
b36c7fb
to
0d6bdb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Azure NFS test