Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mavis Tire Brake to car service center from tire store #10379

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BPowell76
Copy link
Contributor

Mavis Discount Tire (aka Mavis Tires & Brakes) is a tire and car service center. They sell and do tire work, but also will perform oil changes, brakes inspections/work, and suspension work among a few others things.

Changed the main name to Mavis Tires & Brakes as it appeared more often in the stores list than Mavis Discount Tire, but kept both for name matching.

Also added some pre-selected service center options, but these can be removed if need be.

A list of locations to verify the services performed can be found here.

"tags": {
"brand": "Mavis Tire",
"brand:wikidata": "Q65058420",
"name": "Mavis Tire",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the link, I see Mavis Discount Tire and Mavis Tires & Brakes but not Mavis Tire.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of the site's logo

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had the opportunity to fully look into this, but if the company has only two brands, and all stores carry one of the two names, wouldn't it make more sense to split the existing entry into two and drop preserveTags? Otherwise, by using preserveTags and trying to shoehorn one brand into the other, we're not really standardizing anything, and possibly sending bad suggestions to OSM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose so. What if we use Mavis Tire as a preserveTags name and use either of the existing ones as the primary? I think Mavis Tires & Brakes was the more common store name (and would be my vote the "primary name"), but it has been a couple of days since I last looked at it.

@Snowysauce
Copy link
Collaborator

Based on existing entries, service:vehicle:* is a permitted tag group; however, its usage is generally limited to a shop's defining specialty (e.g., "service:vehicle:glass": "yes" for a car repair shop that focuses on glass repairs). There's only one existing entry that has more than two service:vehicle:* tags (tigerwheelandtyre-54a38f), and said entry probably needs a tag cleanup.

@Snowysauce Snowysauce added the fix data Need to cleanup the data in OSM after this is released label Jan 20, 2025
@BPowell76
Copy link
Contributor Author

Based on existing entries, service:vehicle:* is a permitted tag group; however, its usage is generally limited to a shop's defining specialty (e.g., "service:vehicle:glass": "yes" for a car repair shop that focuses on glass repairs). There's only one existing entry that has more than two service:vehicle:* tags (tigerwheelandtyre-54a38f), and said entry probably needs a tag cleanup.

I can change it to just tires if we want to keep it limited to one tag, but I feel that might spark some discussion later on about why it was changed from a tire shop to a car repair shop.

@Snowysauce
Copy link
Collaborator

With the exception of tigerwheelandtyre-54a38f, all-purpose car repair chains in the NSI typically do not have any service:vehicle:* tags in their preset.

@BPowell76
Copy link
Contributor Author

Ok. I'll update it and push a new commit this evening after work.

@BPowell76 BPowell76 requested a review from Cj-Malone January 23, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix data Need to cleanup the data in OSM after this is released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants