-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mavis Tire Brake to car service center from tire store #10379
base: main
Are you sure you want to change the base?
Conversation
data/brands/shop/car_repair.json
Outdated
"tags": { | ||
"brand": "Mavis Tire", | ||
"brand:wikidata": "Q65058420", | ||
"name": "Mavis Tire", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the link, I see Mavis Discount Tire
and Mavis Tires & Brakes
but not Mavis Tire
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had the opportunity to fully look into this, but if the company has only two brands, and all stores carry one of the two names, wouldn't it make more sense to split the existing entry into two and drop preserveTags
? Otherwise, by using preserveTags
and trying to shoehorn one brand into the other, we're not really standardizing anything, and possibly sending bad suggestions to OSM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose so. What if we use Mavis Tire as a preserveTags name and use either of the existing ones as the primary? I think Mavis Tires & Brakes was the more common store name (and would be my vote the "primary name"), but it has been a couple of days since I last looked at it.
Based on existing entries, |
I can change it to just tires if we want to keep it limited to one tag, but I feel that might spark some discussion later on about why it was changed from a tire shop to a car repair shop. |
With the exception of tigerwheelandtyre-54a38f, all-purpose car repair chains in the NSI typically do not have any |
Ok. I'll update it and push a new commit this evening after work. |
Mavis Discount Tire (aka Mavis Tires & Brakes) is a tire and car service center. They sell and do tire work, but also will perform oil changes, brakes inspections/work, and suspension work among a few others things.
Changed the main name to Mavis Tires & Brakes as it appeared more often in the stores list than Mavis Discount Tire, but kept both for name matching.
Also added some pre-selected service center options, but these can be removed if need be.
A list of locations to verify the services performed can be found here.