Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mavis Tire Brake to car service center from tire store #10379

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −13
Open

Update Mavis Tire Brake to car service center from tire store #10379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78f42b0
Update Mavis Tire Brake to car service center from tire store
BPowell76 Jan 20, 2025
55772e8
Make changes to Mavis Tires & Brakes following discussion on PR# 10379
BPowell76 Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions data/brands/shop/car_repair.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,28 @@
"shop": "car_repair"
}
},
{
"displayName": "Mavis Tires & Brakes",
"id": "mavisdiscounttire-db574d",
"locationSet": {"include": ["us"]},
"matchNames": [
"mavis discount tire",
"mavis tires and brakes"
],
"preserveTags": ["^name"],
"tags": {
"brand": "Mavis Tire",
"brand:wikidata": "Q65058420",
"name": "Mavis Tire",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the link, I see Mavis Discount Tire and Mavis Tires & Brakes but not Mavis Tire.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of the site's logo

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had the opportunity to fully look into this, but if the company has only two brands, and all stores carry one of the two names, wouldn't it make more sense to split the existing entry into two and drop preserveTags? Otherwise, by using preserveTags and trying to shoehorn one brand into the other, we're not really standardizing anything, and possibly sending bad suggestions to OSM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose so. What if we use Mavis Tire as a preserveTags name and use either of the existing ones as the primary? I think Mavis Tires & Brakes was the more common store name (and would be my vote the "primary name"), but it has been a couple of days since I last looked at it.

"service:vehicle:oil_change": "yes",
"service:vehicle:tyres": "yes",
"service:vehicle:brakes": "yes",
"service:vehicle:suspension": "yes",
"service:vehicle:tyre_rotation": "yes",
"service:vehicle:alignment": "yes",
"shop": "car_repair"
}
},
{
"displayName": "Meca",
"id": "meca-4150a7",
Expand Down
13 changes: 0 additions & 13 deletions data/brands/shop/tyres.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,19 +356,6 @@
"shop": "tyres"
}
},
{
"displayName": "Mavis Discount Tire",
"id": "mavisdiscounttire-db574d",
"locationSet": {"include": ["us"]},
"matchNames": ["mavis tires & brakes"],
"preserveTags": ["^name"],
"tags": {
"brand": "Mavis Discount Tire",
"brand:wikidata": "Q65058420",
"name": "Mavis Discount Tire",
"shop": "tyres"
}
},
{
"displayName": "Michelin",
"id": "michelin-c3bb11",
Expand Down
Loading