Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toward consistent local (Gazebo) and geographic (GPS) coordinates. #358

Closed
wants to merge 6 commits into from

Conversation

bsb808
Copy link
Collaborator

@bsb808 bsb808 commented Sep 11, 2021

Begins to address Issue #353 .

This PR is on top of PR #354 , so probably best to merge that one first, then rebase before merging.

  • Remove the 180 deg rotation of the Sydney Regatta which causes issue Is the Sydney Regatta map orientation correct? #353.
  • Modification the model pose values insydneyregatta.xacro so that the models (post, ground stations, etc.) are in the same location relative to the Regatta map.
  • Mod. of world file to change camera view
  • Mod. of the launch file change WAM-V default initial pose.

I checked the consistency of the Gazebo / Hector GPS coordinates with Google Earth...

sydney_regatta

I have not yet tried the various VRX tasks to see what other local coordinate values need to be modified to maintain the desired relative location of models.

…ng changes to the xacro and launch files for the local gazebo coordinates to put a few of the elements in the same place relative to the map.
@bsb808 bsb808 changed the title Bsb/use spherical and flipmap Toward consistent local (Gazebo) and geographic (GPS) coordinates. Sep 11, 2021
@M1chaelM
Copy link
Collaborator

@bsb808 Looking at this now. Since it is on top of #354, why don't we change the merge target to bsb/use_spherical so we can test both together before merging either into the master?

@caguero
Copy link
Contributor

caguero commented Sep 11, 2021

Consider to look at this pull request in Ignition Math in case we're impacted with the SphericalCoordinates fix detailed in that PR.

I see that in stationkeeping_scoring_plugin.cc and wildlife_scoring_plugin.cc we're using SphericalFromLocal(). I think we should replace them with:

world->SphericalCoords()->PositionTransform(cartVec,
        ignition::math::SphericalCoordinates::LOCAL2,
        ignition::math::SphericalCoordinates::GLOBAL);

and

world->SphericalCoords()->PositionTransform(pose.Pos(),
        ignition::math::SphericalCoordinates::LOCAL2,
        ignition::math::SphericalCoordinates::GLOBAL);

@bsb808
Copy link
Collaborator Author

bsb808 commented Sep 14, 2021

Also, see #358 - has additional documentation on this issue.

@bsb808
Copy link
Collaborator Author

bsb808 commented Sep 14, 2021

Closing b/c we are working directly on #354

@M1chaelM M1chaelM closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants