Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build system upgrades #406

Merged
merged 135 commits into from
Dec 13, 2024
Merged

Build system upgrades #406

merged 135 commits into from
Dec 13, 2024

Conversation

FallenChromium
Copy link
Collaborator

@FallenChromium FallenChromium commented Sep 3, 2024 •
edited by NikitaZotov
Loading

Main changes:

  • The default way to manage build dependencies has been changed to Conan (we've used OS package managers before)
  • Consuming sc-machine as a library is now much more streamlined: adding it into the CMake tree isn't required anymore
  • Some groundwork has been made to make sc-component-manager more flexible

CD was tested here

Rationale behind the changes: TBD

TO-DO before merging:

Related tasks:

  • Update build system for scp-machine, sc-component-manager, ostis-web-platform
  • Update ostis-example-app

@NikitaZotov NikitaZotov mentioned this pull request Sep 26, 2024
Closed
3 tasks
@NikitaZotov NikitaZotov force-pushed the feat/cmake_external_project branch 17 times, most recently from 6e396a9 to b8c14b4 Compare October 14, 2024 11:17
FallenChromium
FallenChromium commented Oct 14, 2024
View reviewed changes
@FallenChromium
Copy link
Collaborator Author

Current version of extensions path is borked since the current ld paths do not include a way for extensions to link to kpm-common
image

@FallenChromium FallenChromium force-pushed the feat/cmake_external_project branch 4 times, most recently from c7c80f1 to c5fff0a Compare October 15, 2024 19:42
FallenChromium
FallenChromium commented Oct 15, 2024
View reviewed changes
@NikitaZotov NikitaZotov force-pushed the feat/cmake_external_project branch 2 times, most recently from 62f5e05 to bf1b806 Compare October 28, 2024 22:34
kilativ-dotcom
kilativ-dotcom requested changes Dec 5, 2024
View reviewed changes
kilativ-dotcom
kilativ-dotcom requested changes Dec 6, 2024
View reviewed changes
kilativ-dotcom
kilativ-dotcom reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@kilativ-dotcom kilativ-dotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comment in a docker thread

@NikitaZotov NikitaZotov force-pushed the feat/cmake_external_project branch from ac788cb to 6dc08de Compare December 9, 2024 21:24
kilativ-dotcom
kilativ-dotcom reviewed Dec 10, 2024
View reviewed changes
kilativ-dotcom
kilativ-dotcom approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@kilativ-dotcom kilativ-dotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy Birthday! 🎉 🥂 🍰

@NikitaZotov NikitaZotov force-pushed the feat/cmake_external_project branch from abd79a1 to a875241 Compare December 13, 2024 14:53
@NikitaZotov NikitaZotov merged commit 394c525 into main Dec 13, 2024
13 checks passed
@NikitaZotov NikitaZotov mentioned this pull request Dec 17, 2024
Merged
@NikitaZotov NikitaZotov deleted the feat/cmake_external_project branch January 15, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KovalM KovalM KovalM approved these changes

@NikitaZotov NikitaZotov NikitaZotov approved these changes

@kilativ-dotcom kilativ-dotcom kilativ-dotcom approved these changes

Assignees

@FallenChromium FallenChromium

@NikitaZotov NikitaZotov

Labels
0.10.0 build Fix or feat build step ci CI is enhanced enhancement New feature or request
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FallenChromium @NikitaZotov @KovalM @kilativ-dotcom